[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #14: moving to upstream parboiled2 dependency

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on code in PR #14:
URL: https://github.com/apache/incubator-pekko-http/pull/14#discussion_r1105685766


##########
pekko-http-core/src/main/scala/akka/http/impl/model/parser/HeaderParser.scala:
##########
@@ -108,25 +108,25 @@ private[http] object HeaderParser {
 
   object EmptyCookieException extends SingletonException("Cookie header contained no parsable cookie values.")
 
-  def lookupParser(headerName: String, settings: Settings = DefaultSettings): Option[String => HeaderParser#Result] =
-    dispatch.lookup(headerName).map { runner => (value: String) =>

Review Comment:
   We should keep this optimization, maybe we have to keep at our own version of `DynamicRuleDispatch`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org