You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by Guillaume Nodet <gn...@gmail.com> on 2012/05/22 17:05:40 UTC

Problems building karaf trunk

Btw, I've tried to build karaf trunk yesterday and couldn't find a way
to build it fully.
I was starting from a clean repo, but even the root pom was trying to
download some other karaf snapshots, so not sure what happens.
Thoughts ?

-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com

Re: Problems building karaf trunk

Posted by David Jencks <da...@yahoo.com>.
I haven't had a lot of time to look at karaf recently but I really thought I left it so that the build worked in one step, and for this reason I did NOT use the new packagings in the build but instead used pom packaging and explicitly called out the mojos that the packaging uses.  This is infuriating from the perspective of wanting to use our own capabilities but I think necessary for a reasonable release process.

david jencks

On May 23, 2012, at 7:20 AM, Daniel Kulp wrote:

> On Wednesday, May 23, 2012 04:04:05 PM Christian Schneider wrote:
>> I agree. We should redcommend the packaging feature for our end users
>> but not use it in our own build.
> 
> With the caveat that it would good to have an it test or similar that uses 
> the plugin like that to make sure it works properly.  That would be via the 
> maven invoker stuff and thus not subject to the problematic constraints.  
> :-)
> 
> Dan
> 
> 
>> So we have a simple build and people have the convenience of the plugin.
>> 
>> Christian
>> 
>> Am 23.05.2012 15:54, schrieb Guillaume Nodet:
>>> Right, I agree, we could just change the way the assembly is build and
>>> not use our own plugin to simplify the build.
>>> What I meant was I don't think we really want to rework the plugin to
>>> get rid of the new packaging.
> -- 
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
> 


Re: Problems building karaf trunk

Posted by Daniel Kulp <dk...@apache.org>.
On Wednesday, May 23, 2012 04:04:05 PM Christian Schneider wrote:
> I agree. We should redcommend the packaging feature for our end users
> but not use it in our own build.

With the caveat that it would good to have an it test or similar that uses 
the plugin like that to make sure it works properly.  That would be via the 
maven invoker stuff and thus not subject to the problematic constraints.  
:-)

Dan


> So we have a simple build and people have the convenience of the plugin.
> 
> Christian
> 
> Am 23.05.2012 15:54, schrieb Guillaume Nodet:
> > Right, I agree, we could just change the way the assembly is build and
> > not use our own plugin to simplify the build.
> > What I meant was I don't think we really want to rework the plugin to
> > get rid of the new packaging.
-- 
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com


Re: Problems building karaf trunk

Posted by Christian Schneider <ch...@die-schneider.net>.
I agree. We should redcommend the packaging feature for our end users 
but not use it in our own build.
So we have a simple build and people have the convenience of the plugin.

Christian

Am 23.05.2012 15:54, schrieb Guillaume Nodet:
> Right, I agree, we could just change the way the assembly is build and
> not use our own plugin to simplify the build.
> What I meant was I don't think we really want to rework the plugin to
> get rid of the new packaging.
>
>

-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Problems building karaf trunk

Posted by Guillaume Nodet <gn...@gmail.com>.
Right, I agree, we could just change the way the assembly is build and
not use our own plugin to simplify the build.
What I meant was I don't think we really want to rework the plugin to
get rid of the new packaging.

On Wed, May 23, 2012 at 3:50 PM, Daniel Kulp <dk...@apache.org> wrote:
> On Wednesday, May 23, 2012 03:42:17 PM Andreas Pieber wrote:
>> Well... one option might be to release the required components and the
>> karaf-maven-plugin seperatly. Maybe we're able to split those
>> components away far enough to release them separately... I think we
>> might be able to reduce this to a hand of components... Just an idea
>> we would definitely need to dig in deeper to find out the explicit
>> components and which it exactly means to release them separately...
>
> To me, it's easier to just reconfigure the three assembly things that use
> <packaging>feature</packaging> to be pom and configure in the features
> plugin explicitly in the right phases.  But that's me.  :-)    The idea of
> complicating the build system for everyone just to save a little config in
> the poms seems off balance.
>
> Dan
>
>
>>
>> Kind regards,
>> Andreas
>>
>> On Wed, May 23, 2012 at 3:36 PM, Guillaume Nodet <gn...@gmail.com> wrote:
>> > No it doesn't.  We've lived with that in ServiceMix for a few years,
>> > so I'm well aware of the pain btw.
>> >
>> > On Wed, May 23, 2012 at 3:26 PM, Daniel Kulp <dk...@apache.org> wrote:
>> >> On Wednesday, May 23, 2012 10:47:46 AM Guillaume Nodet wrote:
>> >>> I think we need at least a working two step build.
>> >>> It can be done using profiles in the root pom and it has to work from
>> >>> a clean repo.
>> >>
>> >> The problem is that that will likely make the release process much
>> >> harder. Not sure if the maven release plugin would be able to deal
>> >> with multistep build like that.   I'm thinking not.
>> >>
>> >> Dan
>> >>
>> >>> So the first step is to build the maven plugin and the required
>> >>> dependencies, the second one is to build everything (easier than just
>> >>> building the rest).
>> >>> The second step should be the default so that dev is not too much
>> >>> impacted, with a README / BUILDING file explaining the steps to build
>> >>> from a clean state.
>> >>>
>> >>> We can start again the discussion, but IIRC it was deliberate and we
>> >>> knew the problems coming ahead when we accepted djencks changes.
>> >>>
>> >>>
>> >>> On Wed, May 23, 2012 at 9:30 AM, Christian Schneider
>> >>>
>> >>> <ch...@die-schneider.net> wrote:
>> >>> > We already talked about the build on irc but to sum it up here also
>> >>> > on
>> >>> > the list:
>> >>> >
>> >>> > I tested a build of trunk with a clean maven repo. I did not work
>> >>> > out of
>> >>> > the box as the karaf-maven-plugin is required when building the
>> >>> > feature
>> >>> > files. As maven checks that very early the karaf maven plugin is not
>> >>> > yet there.
>> >>> >
>> >>> > So there are three options to really solve that:
>> >>> > - The best solution would be to solve the problem in maven as it
>> >>> > should
>> >>> > not need the plugin so early. There is a very old issue open about
>> >>> > it:
>> >>> > https://jira.codehaus.org/browse/MNG-1911
>> >>> > So it does not seem this is solved soon
>> >>> > - Create a profile in our build that builds up to the
>> >>> > karaf-maven-plugin
>> >>> > as a first step. Then the full build can be run
>> >>> > - Change the feature generation so it does not need a build
>> >>> > extension.
>> >>> > This would require some more maven config than today but may be
>> >>> > worth
>> >>> > it
>> >>> >
>> >>> >
>> >>> > I took a simple workaround by commenting out the assemblies module
>> >>> > in
>> >>> > the
>> >>> > root pom. So the build was failing at the itests but the
>> >>> > karaf-maven-plugin was built.
>> >>> > Then I commented it in again and did a full build which worked.
>> >>> >
>> >>> > Btw. I had a test failure in the kittests which I currently
>> >>> > investigate.
>> >>> >
>> >>> > Christian
>> >>> >
>> >>> > Am 22.05.2012 17:50, schrieb Christian Schneider:
>> >>> >> Am 22.05.2012 17:05, schrieb Guillaume Nodet:
>> >>> >>> Btw, I've tried to build karaf trunk yesterday and couldn't find a
>> >>> >>> way
>> >>> >>> to build it fully.
>> >>> >>> I was starting from a clean repo, but even the root pom was trying
>> >>> >>> to
>> >>> >>> download some other karaf snapshots, so not sure what happens.
>> >>> >>> Thoughts ?
>> >>> >>
>> >>> >> Quite probably these are dependencies that were removed by JBs and
>> >>> >> my
>> >>> >> refactorings but left in the pom accidently. I will take care of
>> >>> >> it.
>> >>> >>
>> >>> >> Christian
>> >>> >
>> >>> > --
>> >>> > Christian Schneider
>> >>> > http://www.liquid-reality.de
>> >>> >
>> >>> > Open Source Architect
>> >>> > Talend Application Integration Division http://www.talend.com
>> >>
>> >> --
>> >> Daniel Kulp
>> >> dkulp@apache.org - http://dankulp.com/blog
>> >> Talend Community Coder - http://coders.talend.com
>> >
>> > --
>> > ------------------------
>> > Guillaume Nodet
>> > ------------------------
>> > Blog: http://gnodet.blogspot.com/
>> > ------------------------
>> > FuseSource, Integration everywhere
>> > http://fusesource.com
> --
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com

Re: Problems building karaf trunk

Posted by Daniel Kulp <dk...@apache.org>.
On Wednesday, May 23, 2012 03:42:17 PM Andreas Pieber wrote:
> Well... one option might be to release the required components and the
> karaf-maven-plugin seperatly. Maybe we're able to split those
> components away far enough to release them separately... I think we
> might be able to reduce this to a hand of components... Just an idea
> we would definitely need to dig in deeper to find out the explicit
> components and which it exactly means to release them separately...

To me, it's easier to just reconfigure the three assembly things that use 
<packaging>feature</packaging> to be pom and configure in the features 
plugin explicitly in the right phases.  But that's me.  :-)    The idea of 
complicating the build system for everyone just to save a little config in 
the poms seems off balance.

Dan


> 
> Kind regards,
> Andreas
> 
> On Wed, May 23, 2012 at 3:36 PM, Guillaume Nodet <gn...@gmail.com> wrote:
> > No it doesn't.  We've lived with that in ServiceMix for a few years,
> > so I'm well aware of the pain btw.
> > 
> > On Wed, May 23, 2012 at 3:26 PM, Daniel Kulp <dk...@apache.org> wrote:
> >> On Wednesday, May 23, 2012 10:47:46 AM Guillaume Nodet wrote:
> >>> I think we need at least a working two step build.
> >>> It can be done using profiles in the root pom and it has to work from
> >>> a clean repo.
> >> 
> >> The problem is that that will likely make the release process much
> >> harder. Not sure if the maven release plugin would be able to deal
> >> with multistep build like that.   I'm thinking not.
> >> 
> >> Dan
> >> 
> >>> So the first step is to build the maven plugin and the required
> >>> dependencies, the second one is to build everything (easier than just
> >>> building the rest).
> >>> The second step should be the default so that dev is not too much
> >>> impacted, with a README / BUILDING file explaining the steps to build
> >>> from a clean state.
> >>> 
> >>> We can start again the discussion, but IIRC it was deliberate and we
> >>> knew the problems coming ahead when we accepted djencks changes.
> >>> 
> >>> 
> >>> On Wed, May 23, 2012 at 9:30 AM, Christian Schneider
> >>> 
> >>> <ch...@die-schneider.net> wrote:
> >>> > We already talked about the build on irc but to sum it up here also
> >>> > on
> >>> > the list:
> >>> > 
> >>> > I tested a build of trunk with a clean maven repo. I did not work
> >>> > out of
> >>> > the box as the karaf-maven-plugin is required when building the
> >>> > feature
> >>> > files. As maven checks that very early the karaf maven plugin is not
> >>> > yet there.
> >>> > 
> >>> > So there are three options to really solve that:
> >>> > - The best solution would be to solve the problem in maven as it
> >>> > should
> >>> > not need the plugin so early. There is a very old issue open about
> >>> > it:
> >>> > https://jira.codehaus.org/browse/MNG-1911
> >>> > So it does not seem this is solved soon
> >>> > - Create a profile in our build that builds up to the
> >>> > karaf-maven-plugin
> >>> > as a first step. Then the full build can be run
> >>> > - Change the feature generation so it does not need a build
> >>> > extension.
> >>> > This would require some more maven config than today but may be
> >>> > worth
> >>> > it
> >>> > 
> >>> > 
> >>> > I took a simple workaround by commenting out the assemblies module
> >>> > in
> >>> > the
> >>> > root pom. So the build was failing at the itests but the
> >>> > karaf-maven-plugin was built.
> >>> > Then I commented it in again and did a full build which worked.
> >>> > 
> >>> > Btw. I had a test failure in the kittests which I currently
> >>> > investigate.
> >>> > 
> >>> > Christian
> >>> > 
> >>> > Am 22.05.2012 17:50, schrieb Christian Schneider:
> >>> >> Am 22.05.2012 17:05, schrieb Guillaume Nodet:
> >>> >>> Btw, I've tried to build karaf trunk yesterday and couldn't find a
> >>> >>> way
> >>> >>> to build it fully.
> >>> >>> I was starting from a clean repo, but even the root pom was trying
> >>> >>> to
> >>> >>> download some other karaf snapshots, so not sure what happens.
> >>> >>> Thoughts ?
> >>> >> 
> >>> >> Quite probably these are dependencies that were removed by JBs and
> >>> >> my
> >>> >> refactorings but left in the pom accidently. I will take care of
> >>> >> it.
> >>> >> 
> >>> >> Christian
> >>> > 
> >>> > --
> >>> > Christian Schneider
> >>> > http://www.liquid-reality.de
> >>> > 
> >>> > Open Source Architect
> >>> > Talend Application Integration Division http://www.talend.com
> >> 
> >> --
> >> Daniel Kulp
> >> dkulp@apache.org - http://dankulp.com/blog
> >> Talend Community Coder - http://coders.talend.com
> > 
> > --
> > ------------------------
> > Guillaume Nodet
> > ------------------------
> > Blog: http://gnodet.blogspot.com/
> > ------------------------
> > FuseSource, Integration everywhere
> > http://fusesource.com
-- 
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com


Re: Problems building karaf trunk

Posted by Christian Schneider <ch...@die-schneider.net>.
Also thought about that but the karaf-maven-plugin needs the feature 
service which is a core part of karaf. So I am not sure this would work.

Christian


Am 23.05.2012 15:42, schrieb Andreas Pieber:
> Well... one option might be to release the required components and the
> karaf-maven-plugin seperatly. Maybe we're able to split those
> components away far enough to release them separately... I think we
> might be able to reduce this to a hand of components... Just an idea
> we would definitely need to dig in deeper to find out the explicit
> components and which it exactly means to release them separately...
>
> Kind regards,
> Andreas
>

-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Problems building karaf trunk

Posted by Andreas Pieber <an...@gmail.com>.
Well... one option might be to release the required components and the
karaf-maven-plugin seperatly. Maybe we're able to split those
components away far enough to release them separately... I think we
might be able to reduce this to a hand of components... Just an idea
we would definitely need to dig in deeper to find out the explicit
components and which it exactly means to release them separately...

Kind regards,
Andreas

On Wed, May 23, 2012 at 3:36 PM, Guillaume Nodet <gn...@gmail.com> wrote:
> No it doesn't.  We've lived with that in ServiceMix for a few years,
> so I'm well aware of the pain btw.
>
> On Wed, May 23, 2012 at 3:26 PM, Daniel Kulp <dk...@apache.org> wrote:
>> On Wednesday, May 23, 2012 10:47:46 AM Guillaume Nodet wrote:
>>> I think we need at least a working two step build.
>>> It can be done using profiles in the root pom and it has to work from
>>> a clean repo.
>>
>> The problem is that that will likely make the release process much harder.
>> Not sure if the maven release plugin would be able to deal with multistep
>> build like that.   I'm thinking not.
>>
>> Dan
>>
>>
>>
>>> So the first step is to build the maven plugin and the required
>>> dependencies, the second one is to build everything (easier than just
>>> building the rest).
>>> The second step should be the default so that dev is not too much
>>> impacted, with a README / BUILDING file explaining the steps to build
>>> from a clean state.
>>>
>>> We can start again the discussion, but IIRC it was deliberate and we
>>> knew the problems coming ahead when we accepted djencks changes.
>>>
>>>
>>> On Wed, May 23, 2012 at 9:30 AM, Christian Schneider
>>>
>>> <ch...@die-schneider.net> wrote:
>>> > We already talked about the build on irc but to sum it up here also on
>>> > the list:
>>> >
>>> > I tested a build of trunk with a clean maven repo. I did not work out of
>>> > the box as the karaf-maven-plugin is required when building the feature
>>> > files. As maven checks that very early the karaf maven plugin is not
>>> > yet there.
>>> >
>>> > So there are three options to really solve that:
>>> > - The best solution would be to solve the problem in maven as it should
>>> > not need the plugin so early. There is a very old issue open about it:
>>> > https://jira.codehaus.org/browse/MNG-1911
>>> > So it does not seem this is solved soon
>>> > - Create a profile in our build that builds up to the karaf-maven-plugin
>>> > as a first step. Then the full build can be run
>>> > - Change the feature generation so it does not need a build extension.
>>> > This would require some more maven config than today but may be worth
>>> > it
>>> >
>>> >
>>> > I took a simple workaround by commenting out the assemblies module in
>>> > the
>>> > root pom. So the build was failing at the itests but the
>>> > karaf-maven-plugin was built.
>>> > Then I commented it in again and did a full build which worked.
>>> >
>>> > Btw. I had a test failure in the kittests which I currently investigate.
>>> >
>>> > Christian
>>> >
>>> > Am 22.05.2012 17:50, schrieb Christian Schneider:
>>> >> Am 22.05.2012 17:05, schrieb Guillaume Nodet:
>>> >>> Btw, I've tried to build karaf trunk yesterday and couldn't find a way
>>> >>> to build it fully.
>>> >>> I was starting from a clean repo, but even the root pom was trying to
>>> >>> download some other karaf snapshots, so not sure what happens.
>>> >>> Thoughts ?
>>> >>
>>> >> Quite probably these are dependencies that were removed by JBs and my
>>> >> refactorings but left in the pom accidently. I will take care of it.
>>> >>
>>> >> Christian
>>> >
>>> > --
>>> > Christian Schneider
>>> > http://www.liquid-reality.de
>>> >
>>> > Open Source Architect
>>> > Talend Application Integration Division http://www.talend.com
>> --
>> Daniel Kulp
>> dkulp@apache.org - http://dankulp.com/blog
>> Talend Community Coder - http://coders.talend.com
>>
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com

Re: Problems building karaf trunk

Posted by Guillaume Nodet <gn...@gmail.com>.
No it doesn't.  We've lived with that in ServiceMix for a few years,
so I'm well aware of the pain btw.

On Wed, May 23, 2012 at 3:26 PM, Daniel Kulp <dk...@apache.org> wrote:
> On Wednesday, May 23, 2012 10:47:46 AM Guillaume Nodet wrote:
>> I think we need at least a working two step build.
>> It can be done using profiles in the root pom and it has to work from
>> a clean repo.
>
> The problem is that that will likely make the release process much harder.
> Not sure if the maven release plugin would be able to deal with multistep
> build like that.   I'm thinking not.
>
> Dan
>
>
>
>> So the first step is to build the maven plugin and the required
>> dependencies, the second one is to build everything (easier than just
>> building the rest).
>> The second step should be the default so that dev is not too much
>> impacted, with a README / BUILDING file explaining the steps to build
>> from a clean state.
>>
>> We can start again the discussion, but IIRC it was deliberate and we
>> knew the problems coming ahead when we accepted djencks changes.
>>
>>
>> On Wed, May 23, 2012 at 9:30 AM, Christian Schneider
>>
>> <ch...@die-schneider.net> wrote:
>> > We already talked about the build on irc but to sum it up here also on
>> > the list:
>> >
>> > I tested a build of trunk with a clean maven repo. I did not work out of
>> > the box as the karaf-maven-plugin is required when building the feature
>> > files. As maven checks that very early the karaf maven plugin is not
>> > yet there.
>> >
>> > So there are three options to really solve that:
>> > - The best solution would be to solve the problem in maven as it should
>> > not need the plugin so early. There is a very old issue open about it:
>> > https://jira.codehaus.org/browse/MNG-1911
>> > So it does not seem this is solved soon
>> > - Create a profile in our build that builds up to the karaf-maven-plugin
>> > as a first step. Then the full build can be run
>> > - Change the feature generation so it does not need a build extension.
>> > This would require some more maven config than today but may be worth
>> > it
>> >
>> >
>> > I took a simple workaround by commenting out the assemblies module in
>> > the
>> > root pom. So the build was failing at the itests but the
>> > karaf-maven-plugin was built.
>> > Then I commented it in again and did a full build which worked.
>> >
>> > Btw. I had a test failure in the kittests which I currently investigate.
>> >
>> > Christian
>> >
>> > Am 22.05.2012 17:50, schrieb Christian Schneider:
>> >> Am 22.05.2012 17:05, schrieb Guillaume Nodet:
>> >>> Btw, I've tried to build karaf trunk yesterday and couldn't find a way
>> >>> to build it fully.
>> >>> I was starting from a clean repo, but even the root pom was trying to
>> >>> download some other karaf snapshots, so not sure what happens.
>> >>> Thoughts ?
>> >>
>> >> Quite probably these are dependencies that were removed by JBs and my
>> >> refactorings but left in the pom accidently. I will take care of it.
>> >>
>> >> Christian
>> >
>> > --
>> > Christian Schneider
>> > http://www.liquid-reality.de
>> >
>> > Open Source Architect
>> > Talend Application Integration Division http://www.talend.com
> --
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com

Re: Problems building karaf trunk

Posted by Daniel Kulp <dk...@apache.org>.
On Wednesday, May 23, 2012 10:47:46 AM Guillaume Nodet wrote:
> I think we need at least a working two step build.
> It can be done using profiles in the root pom and it has to work from
> a clean repo.

The problem is that that will likely make the release process much harder.   
Not sure if the maven release plugin would be able to deal with multistep 
build like that.   I'm thinking not.

Dan



> So the first step is to build the maven plugin and the required
> dependencies, the second one is to build everything (easier than just
> building the rest).
> The second step should be the default so that dev is not too much
> impacted, with a README / BUILDING file explaining the steps to build
> from a clean state.
> 
> We can start again the discussion, but IIRC it was deliberate and we
> knew the problems coming ahead when we accepted djencks changes.
> 
> 
> On Wed, May 23, 2012 at 9:30 AM, Christian Schneider
> 
> <ch...@die-schneider.net> wrote:
> > We already talked about the build on irc but to sum it up here also on
> > the list:
> > 
> > I tested a build of trunk with a clean maven repo. I did not work out of
> > the box as the karaf-maven-plugin is required when building the feature
> > files. As maven checks that very early the karaf maven plugin is not
> > yet there.
> > 
> > So there are three options to really solve that:
> > - The best solution would be to solve the problem in maven as it should
> > not need the plugin so early. There is a very old issue open about it:
> > https://jira.codehaus.org/browse/MNG-1911
> > So it does not seem this is solved soon
> > - Create a profile in our build that builds up to the karaf-maven-plugin
> > as a first step. Then the full build can be run
> > - Change the feature generation so it does not need a build extension.
> > This would require some more maven config than today but may be worth
> > it
> > 
> > 
> > I took a simple workaround by commenting out the assemblies module in
> > the
> > root pom. So the build was failing at the itests but the
> > karaf-maven-plugin was built.
> > Then I commented it in again and did a full build which worked.
> > 
> > Btw. I had a test failure in the kittests which I currently investigate.
> > 
> > Christian
> > 
> > Am 22.05.2012 17:50, schrieb Christian Schneider:
> >> Am 22.05.2012 17:05, schrieb Guillaume Nodet:
> >>> Btw, I've tried to build karaf trunk yesterday and couldn't find a way
> >>> to build it fully.
> >>> I was starting from a clean repo, but even the root pom was trying to
> >>> download some other karaf snapshots, so not sure what happens.
> >>> Thoughts ?
> >> 
> >> Quite probably these are dependencies that were removed by JBs and my
> >> refactorings but left in the pom accidently. I will take care of it.
> >> 
> >> Christian
> > 
> > --
> > Christian Schneider
> > http://www.liquid-reality.de
> > 
> > Open Source Architect
> > Talend Application Integration Division http://www.talend.com
-- 
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com


Re: Problems building karaf trunk

Posted by Guillaume Nodet <gn...@gmail.com>.
I think we need at least a working two step build.
It can be done using profiles in the root pom and it has to work from
a clean repo.
So the first step is to build the maven plugin and the required
dependencies, the second one is to build everything (easier than just
building the rest).
The second step should be the default so that dev is not too much
impacted, with a README / BUILDING file explaining the steps to build
from a clean state.

We can start again the discussion, but IIRC it was deliberate and we
knew the problems coming ahead when we accepted djencks changes.


On Wed, May 23, 2012 at 9:30 AM, Christian Schneider
<ch...@die-schneider.net> wrote:
> We already talked about the build on irc but to sum it up here also on the
> list:
>
> I tested a build of trunk with a clean maven repo. I did not work out of the
> box as the karaf-maven-plugin is required when building the feature files.
> As maven checks that very early the karaf maven plugin is not yet there.
>
> So there are three options to really solve that:
> - The best solution would be to solve the problem in maven as it should not
> need the plugin so early. There is a very old issue open about it:
> https://jira.codehaus.org/browse/MNG-1911
> So it does not seem this is solved soon
> - Create a profile in our build that builds up to the karaf-maven-plugin as
> a first step. Then the full build can be run
> - Change the feature generation so it does not need a build extension. This
> would require some more maven config than today but may be worth it
>
>
> I took a simple workaround by commenting out the assemblies module in the
> root pom. So the build was failing at the itests but the karaf-maven-plugin
> was built.
> Then I commented it in again and did a full build which worked.
>
> Btw. I had a test failure in the kittests which I currently investigate.
>
> Christian
>
> Am 22.05.2012 17:50, schrieb Christian Schneider:
>
>> Am 22.05.2012 17:05, schrieb Guillaume Nodet:
>>>
>>> Btw, I've tried to build karaf trunk yesterday and couldn't find a way
>>> to build it fully.
>>> I was starting from a clean repo, but even the root pom was trying to
>>> download some other karaf snapshots, so not sure what happens.
>>> Thoughts ?
>>>
>> Quite probably these are dependencies that were removed by JBs and my
>> refactorings but left in the pom accidently. I will take care of it.
>>
>> Christian
>>
>>
>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com

Re: Problems building karaf trunk

Posted by Christian Schneider <ch...@die-schneider.net>.
We already talked about the build on irc but to sum it up here also on 
the list:

I tested a build of trunk with a clean maven repo. I did not work out of 
the box as the karaf-maven-plugin is required when building the feature 
files. As maven checks that very early the karaf maven plugin is not yet 
there.

So there are three options to really solve that:
- The best solution would be to solve the problem in maven as it should 
not need the plugin so early. There is a very old issue open about it: 
https://jira.codehaus.org/browse/MNG-1911
So it does not seem this is solved soon
- Create a profile in our build that builds up to the karaf-maven-plugin 
as a first step. Then the full build can be run
- Change the feature generation so it does not need a build extension. 
This would require some more maven config than today but may be worth it


I took a simple workaround by commenting out the assemblies module in 
the root pom. So the build was failing at the itests but the 
karaf-maven-plugin was built.
Then I commented it in again and did a full build which worked.

Btw. I had a test failure in the kittests which I currently investigate.

Christian

Am 22.05.2012 17:50, schrieb Christian Schneider:
> Am 22.05.2012 17:05, schrieb Guillaume Nodet:
>> Btw, I've tried to build karaf trunk yesterday and couldn't find a way
>> to build it fully.
>> I was starting from a clean repo, but even the root pom was trying to
>> download some other karaf snapshots, so not sure what happens.
>> Thoughts ?
>>
> Quite probably these are dependencies that were removed by JBs and my 
> refactorings but left in the pom accidently. I will take care of it.
>
> Christian
>
>


-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Problems building karaf trunk

Posted by Christian Schneider <ch...@die-schneider.net>.
Am 22.05.2012 17:05, schrieb Guillaume Nodet:
> Btw, I've tried to build karaf trunk yesterday and couldn't find a way
> to build it fully.
> I was starting from a clean repo, but even the root pom was trying to
> download some other karaf snapshots, so not sure what happens.
> Thoughts ?
>
Quite probably these are dependencies that were removed by JBs and my 
refactorings but left in the pom accidently. I will take care of it.

Christian


-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com