You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Josh McKenzie (Jira)" <ji...@apache.org> on 2025/05/27 19:40:00 UTC

[jira] [Commented] (CASSANDRA-20422) improve the golang download when building source code

    [ https://issues.apache.org/jira/browse/CASSANDRA-20422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954404#comment-17954404 ] 

Josh McKenzie commented on CASSANDRA-20422:
-------------------------------------------

It looks like this patch added {{gen-doc}} as a dependency to the {{ant check}} target. That feels a little messy to me. Also a little surprised that wasn't on the [PR|https://github.com/apache/cassandra/pull/3966/files] but showed up [in the commit|https://github.com/apache/cassandra/commit/e16f30c58711185d333af2e8ef2ed1e91af9e32c#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021R551] looks like?

What if we instead just have a pipeline in CI that confirms {{ant gen-doc}} works so we don't end up with the odd coupling of "when you run checkstyle, docs also get generated"? Or was there some intentional strategy behind that that's just not immediately obvious? 

> improve the golang download when building source code
> -----------------------------------------------------
>
>                 Key: CASSANDRA-20422
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20422
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Ling Mao
>            Assignee: Ling Mao
>            Priority: Low
>             Fix For: 5.0.4, 5.1
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> 1. Optimized the download process for Go (Golang) to make it faster if you already have it installed locally. Every build typically requires fetching Go, which can be time-consuming
> 2. In regions where access to Google is restricted (e.g., China), the build process can hang indefinitely while attempting to download Go. To address this, we can enhance the wget command by adding timeout and retry options.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org