You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by EronWright <gi...@git.apache.org> on 2017/05/10 17:16:42 UTC

[GitHub] flink pull request #3867: [FLINK-6531] Deserialize checkpoint hooks with use...

GitHub user EronWright opened a pull request:

    https://github.com/apache/flink/pull/3867

    [FLINK-6531] Deserialize checkpoint hooks with user classloader

    - enhance MasterTriggerRestoreHook.Factory::create to take user-code classloader
    - deserialize WithMasterCheckpointHook instance with supplied classloader
    - throw JobExecutionException when hook cannot be instantiated


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/EronWright/flink FLINK-6531

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3867
    
----
commit 7e94a9be59bff643150c08e73a292436c557cd8a
Author: Wright, Eron <er...@emc.com>
Date:   2017-05-10T17:14:54Z

    FLINK-6531
    
    - enhance MasterTriggerRestoreHook.Factory::create to take user-code classloader
    - deserialize WithMasterCheckpointHook instance with supplied classloader
    - throw JobExecutionException when hook cannot be instantiated

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3867: [FLINK-6531] Deserialize checkpoint hooks with user class...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3867
  
    Thanks for this patch, this is crucial!
    
    There is a slightly different approach I would suggest, to not assume that the `Factory` is always in the core classpath. I have the code for that almost ready, plus a test. Can open a PR for your review shortly...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3867: [FLINK-6531] Deserialize checkpoint hooks with user class...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3867
  
    @EronWright Here is a slightly modified version of your code: https://github.com/apache/flink/pull/3868
    
    I added a small test to also validate the class loading.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3867: [FLINK-6531] Deserialize checkpoint hooks with use...

Posted by EronWright <gi...@git.apache.org>.
Github user EronWright closed the pull request at:

    https://github.com/apache/flink/pull/3867


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---