You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2023/01/10 09:03:05 UTC

[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

pbacsko commented on code in PR #511:
URL: https://github.com/apache/yunikorn-k8shim/pull/511#discussion_r1065506290


##########
test/e2e/framework/helpers/yunikorn/rest_api_utils.go:
##########
@@ -404,12 +406,13 @@ func (c *RClient) LogNodesInfo(outputDir string) error {
 	return err
 }
 
-func (c *RClient) GetPartitions() (*dao.PartitionDAOInfo, error) {
-	req, err := c.newRequest("GET", configmanager.QueuesPath, nil)
+func (c *RClient) GetPartitions(partition string) (*dao.PartitionQueueDAOInfo, error) {
+	req, err := c.newRequest("GET", fmt.Sprintf(configmanager.QueuesPath, partition), nil)
 	if err != nil {
 		return nil, err
 	}
-	partitions := new(dao.PartitionDAOInfo)
-	_, err = c.do(req, partitions)
+	// partitions := new(dao.PartitionDAOInfo)

Review Comment:
   Nit: unnecessary comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org