You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by bdesert <gi...@git.apache.org> on 2018/03/13 05:54:18 UTC
[GitHub] nifi pull request #2537: fix printing indefinite log errors
GitHub user bdesert opened a pull request:
https://github.com/apache/nifi/pull/2537
fix printing indefinite log errors
Added fix to avoid printing indefinite errors to logs in customValidate after first failed validation until any property is modified.
-----
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bdesert/nifi NIFI-4968-ISP-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2537
----
commit e105705da30ac72551433ddf2027d90a590ae73a
Author: Ed <ed...@...>
Date: 2018-03-13T05:49:04Z
fix printing indefinite log errors
After first failure in customValidate, stop printing logs until any property is changed
----
---
[GitHub] nifi pull request #2537: NIFI-4968 fix printing indefinite log errors
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2537
---
[GitHub] nifi issue #2537: fix printing indefinite log errors
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2537
@bdesert - could you amend your PR to include the JIRA number in the title? it allows the hook between github and JIRA to work properly and it's easier to find the JIRA related to the PR.
For reviewers, this PR is for NIFI-4968 (https://issues.apache.org/jira/browse/NIFI-4968).
---
[GitHub] nifi issue #2537: fix printing indefinite log errors
Posted by bdesert <gi...@git.apache.org>.
Github user bdesert commented on the issue:
https://github.com/apache/nifi/pull/2537
@mattyb149 , can you please review the changes?
---
[GitHub] nifi issue #2537: NIFI-4968 fix printing indefinite log errors
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2537
+1 LGTM, ran unit tests and tried with a live NiFi instance, verified the behavior is as expected. Thanks for the improvement! Merging to master
---