You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/12/08 15:05:50 UTC
[GitHub] [activemq-artemis] gtully opened a new pull request #3875: fix intermittent failure of org.apache.activemq.artemis.tests.integra…
gtully opened a new pull request #3875:
URL: https://github.com/apache/activemq-artemis/pull/3875
…tion.client.ConsumerTest#testSendAMQPReceiveCore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully merged pull request #3875: fix intermittent failure of org.apache.activemq.artemis.tests.integra…
Posted by GitBox <gi...@apache.org>.
gtully merged pull request #3875:
URL: https://github.com/apache/activemq-artemis/pull/3875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3875: fix intermittent failure of org.apache.activemq.artemis.tests.integra…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3875:
URL: https://github.com/apache/activemq-artemis/pull/3875#discussion_r765053525
##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -971,6 +971,9 @@ protected synchronized void lazyScanAfterReloadPersistence() {
scanMessageData();
messageDataScanned = MessageDataScanningStatus.SCANNED.code;
modified = false;
+ // reinitialise memory estimate as message will already be on a queue
+ // and lazy decode will want to update
+ getMemoryEstimate();
Review comment:
wow.. nice catch!
if this fixes the issue.. go for it! Merge it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org