[veltools] unused StrutsUtils methods

[Nathan Bubna <na...@esha.com>]

hey folks,

after going through the classes sprucing up javadoc today, i realized that
there are quite a few methods in the StrutsUtils class that are used nowhere
else in the VelocityTools project.  in fact, there are so many in that
category that it is easier to list here the ones which *are* used by
VelocityTools:

getMessageResources(req,app)
getMessageResources(req,app,bundle)
selectModule(path,app)   <-- will be unnecessary with Struts 1.2
getLocale(req,sess)
getToken(sess)
getActionErrors(req)
getActionMessages(req)
getActionConfig(req)
getActionForm(req,sess)
getActionMappingURL(...)
getForwardURL(...)
errorMarkup(...)

a few other methods are used but only once:
getForwardConfig(path,req,app) <-- used only 1x by StrutsUtils
getServletMapping(app) <-- used only 1x by StrutsUtils
getCancelName()  <-- used only 1x by FormTool
getGlobalErrorName() <-- used only 1x by ErrorsTool
getTokenName() <-- used only 1x by FormTool

it seems to me that there is no reason to keep the other methods around.  in
particular, i see no reason to keep the unused methods that have been added
since our 1.0 release.  StrutsUtils was never meant to be what it has become.
Ideally, it was hoped that changes to Struts (see
http://issues.apache.org/bugzilla/show_bug.cgi?id=16814) would make it
entirely unnecessary.  at this point, i don't think StrutsUtils will ever
completely go away, but i would still like to keep it to a minimum.

as such, i propose we:
-deprecate all unused or once used methods released in 1.0
-remove the unused methods added since 1.0

speak soon or forever hold your peace. :)

Nathan Bubna
nathan@esha.com


---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org

RE: [veltools] unused StrutsUtils methods

["Marinó A. Jónsson" <ma...@centrum.is>]

I won't miss them :)

Marinó.

> -----Original Message-----
> From: Nathan Bubna [mailto:nathan@esha.com] 
> Sent: 6. nóvember 2003 01:28
> To: velocity-dev@jakarta.apache.org
> Subject: [veltools] unused StrutsUtils methods
> 
> 
> hey folks,
> 
> after going through the classes sprucing up javadoc today, i 
> realized that there are quite a few methods in the 
> StrutsUtils class that are used nowhere else in the 
> VelocityTools project.  in fact, there are so many in that 
> category that it is easier to list here the ones which *are* used by
> VelocityTools:
> 
> getMessageResources(req,app)
> getMessageResources(req,app,bundle)
> selectModule(path,app)   <-- will be unnecessary with Struts 1.2
> getLocale(req,sess)
> getToken(sess)
> getActionErrors(req)
> getActionMessages(req)
> getActionConfig(req)
> getActionForm(req,sess)
> getActionMappingURL(...)
> getForwardURL(...)
> errorMarkup(...)
> 
> a few other methods are used but only once:
> getForwardConfig(path,req,app) <-- used only 1x by StrutsUtils
> getServletMapping(app) <-- used only 1x by StrutsUtils
> getCancelName()  <-- used only 1x by FormTool
> getGlobalErrorName() <-- used only 1x by ErrorsTool
> getTokenName() <-- used only 1x by FormTool
> 
> it seems to me that there is no reason to keep the other 
> methods around.  in particular, i see no reason to keep the 
> unused methods that have been added since our 1.0 release.  
> StrutsUtils was never meant to be what it has become. 
> Ideally, it was hoped that changes to Struts (see
> http://issues.apache.org/bugzilla/show_bug.cgi?id=16814) 
> would make it entirely unnecessary.  at this point, i don't 
> think StrutsUtils will ever completely go away, but i would 
> still like to keep it to a minimum.
> 
> as such, i propose we:
> -deprecate all unused or once used methods released in 1.0 
> -remove the unused methods added since 1.0
> 
> speak soon or forever hold your peace. :)
> 
> Nathan Bubna
> nathan@esha.com
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
> 
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org