You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/12/12 19:53:25 UTC

[GitHub] [thrift] alisaifee commented on pull request #2487: THRIFT-5488: Define PY_SSIZE_T_CLEAN to fix error with using PyObject_CallFunction in python 3.10

alisaifee commented on pull request #2487:
URL: https://github.com/apache/thrift/pull/2487#issuecomment-991959949


   I realized I hadn't added any details about using the unit tests to verify the behavior before and after the patch - added now. 
   
   Regarding the CI -  the build is failing at the moment due to a rust dependency issue (`clap`: `use of unstable library feature 'matches_macro'`) which I also get locally. However, I didn't see the where the python unit tests would be run. Adding `-Werror` does sound like a good direction though! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org