You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/23 04:02:40 UTC

[GitHub] [incubator-nuttx] btashton opened a new pull request #2383: USB: Do not try to print NULL format strings for verbose trace messages when disabled

btashton opened a new pull request #2383:
URL: https://github.com/apache/incubator-nuttx/pull/2383


   ## Summary
   Right now if usb tracing is enabled but verbose is disabled a debug assert will be triggered when ever a verbose trace point is hit because the return format pointer would be NULL (by design).  Instead of trying to print the NULL message, just return early.  This does not change any normal functionality.
   
   ## Impact
   USB tracing can be enabled in non-verbose mode with debug asserts on.
   
   ## Testing
   nucleo-h745iz:otg_fs_host with debug asserts enabled and trace on.  Prior this change it would hit the assert right away.  
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2383: USB: Do not try to print NULL format strings for verbose trace messages when disabled

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2383:
URL: https://github.com/apache/incubator-nuttx/pull/2383


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org