You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/21 21:02:35 UTC
[GitHub] [trafficserver] duke8253 opened a new pull request #7968: STEK Share Plugin
duke8253 opened a new pull request #7968:
URL: https://github.com/apache/trafficserver/pull/7968
This is a plugin used to share STEK among a cluster of ATS instances. It'll replace the current session reuse plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] commented on pull request #7968: STEK Share Plugin
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7968:
URL: https://github.com/apache/trafficserver/pull/7968#issuecomment-923511892
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] closed pull request #7968: STEK Share Plugin
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #7968:
URL: https://github.com/apache/trafficserver/pull/7968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #7968: STEK Share Plugin
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #7968:
URL: https://github.com/apache/trafficserver/pull/7968#discussion_r656625665
##########
File path: plugins/experimental/stek_share/common.h
##########
@@ -0,0 +1,67 @@
+/** @file
+
+ commmon.h - Things that need to be everywhere
+
+ @section license License
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+ */
+
+#pragma once
+
+#include <iostream>
+#include <iomanip>
+#include <string>
+#include <cstring>
+#include <mutex>
+#include <deque>
+#include <cmath>
+
+#define PLUGIN "stek_share"
+
+class PluginThreads
Review comment:
Oh nevermind. I didn't have all the files opened up. I see its use now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] closed pull request #7968: STEK Share Plugin
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #7968:
URL: https://github.com/apache/trafficserver/pull/7968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] duke8253 commented on a change in pull request #7968: STEK Share Plugin
Posted by GitBox <gi...@apache.org>.
duke8253 commented on a change in pull request #7968:
URL: https://github.com/apache/trafficserver/pull/7968#discussion_r656625247
##########
File path: plugins/experimental/stek_share/common.h
##########
@@ -0,0 +1,67 @@
+/** @file
+
+ commmon.h - Things that need to be everywhere
+
+ @section license License
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+ */
+
+#pragma once
+
+#include <iostream>
+#include <iomanip>
+#include <string>
+#include <cstring>
+#include <mutex>
+#include <deque>
+#include <cmath>
+
+#define PLUGIN "stek_share"
+
+class PluginThreads
Review comment:
Yeah, this is for shutting down threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #7968: STEK Share Plugin
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #7968:
URL: https://github.com/apache/trafficserver/pull/7968#discussion_r656623743
##########
File path: plugins/experimental/stek_share/common.h
##########
@@ -0,0 +1,67 @@
+/** @file
+
+ commmon.h - Things that need to be everywhere
+
+ @section license License
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+ */
+
+#pragma once
+
+#include <iostream>
+#include <iomanip>
+#include <string>
+#include <cstring>
+#include <mutex>
+#include <deque>
+#include <cmath>
+
+#define PLUGIN "stek_share"
+
+class PluginThreads
Review comment:
Is the PluginThreads class used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org