[mynewt-nimble] branch master updated: nimble/ll: Do not nak PDU with RFU LLID

[an...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git


The following commit(s) were added to refs/heads/master by this push:
     new def9fd0  nimble/ll: Do not nak PDU with RFU LLID
def9fd0 is described below

commit def9fd043744c72d7e35aa81a6a592e941531bb2
Author: Andrzej Kaczmarek <an...@codecoup.pl>
AuthorDate: Fri Feb 25 12:05:46 2022 +0100

    nimble/ll: Do not nak PDU with RFU LLID
    
    We can handle such PDU in isr, it will be then ignored in LL.
    
    This fixes LL/CON/CEN/BI-14-C and LL/CON/PER/BI-17-C.
---
 nimble/controller/src/ble_ll_conn.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/nimble/controller/src/ble_ll_conn.c b/nimble/controller/src/ble_ll_conn.c
index d1725f2..c2739f1 100644
--- a/nimble/controller/src/ble_ll_conn.c
+++ b/nimble/controller/src/ble_ll_conn.c
@@ -3417,16 +3417,6 @@ ble_ll_conn_rx_isr_end(uint8_t *rxbuf, struct ble_mbuf_hdr *rxhdr)
         /* Set last valid received pdu time (resets supervision timer) */
         connsm->last_rxd_pdu_cputime = begtime + ble_ll_tmr_u2t(add_usecs);
 
-        /*
-         * Check for valid LLID before proceeding. We have seen some weird
-         * things with the PHY where the CRC is OK but we dont have a valid
-         * LLID. This should really never happen but if it does we will just
-         * bail. An error stat will get incremented at the LL.
-         */
-        if ((hdr_byte & BLE_LL_DATA_HDR_LLID_MASK) == 0) {
-            goto conn_exit;
-        }
-
         /* Set last received header byte */
         connsm->last_rxd_hdr_byte = hdr_byte;