[jira] Commented: (AXIS2C-830) libcurl interface not multithreaded

["Senaka Fernando (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2C-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551467 ] 

Senaka Fernando commented on AXIS2C-830:
----------------------------------------

Hi Bill,

I read through your diff. And, also src/core/transport/http/sender/libcurl/axis2_libcurl.c. It seems that the curl handle is used only within the axis2_libcurl_send() method. ***Am I making a mistake here?*** Thus, instead of being a static definition you simply can make it a local variable inside the method call.

Also, curl_global_init() is not required if you wont call curl_global_cleanup(). curl_easy_init() will do it for you[1]. And, even this could be a leak in terms of a leak-detector; since, curl's global resources need to be persistent throughout the program's life, it would not rather be a leak in reality.

However, the leak inside axis2_libcurl_write_memory_callback() needs a fix (+1) I guess, and I believe you have remedied the issue.

References:
[1]http://curl.rtin.bz/libcurl/c/libcurl.html

Regards,
Senaka

> libcurl interface not multithreaded
> -----------------------------------
>
>                 Key: AXIS2C-830
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-830
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: transport/http
>    Affects Versions: 1.1.0
>         Environment: Windows XP, Visual Studio 2005, build uses libcurl and guththila
>            Reporter: Bill Mitchell
>         Attachments: libcurl_diff
>
>
> Axis2C support of libcurl is not multithreaded, i.e., it cannot be invoked by a multithreaded client application.  This despite the fact that libcurl is multithreaded and Axis2C is multithreaded.  The crux of the issue lies in the static global definition of the curl handler in axis2_libcurl.c.  This prevents multiple client threads from obtaining multiple connections to issue concurrent SOAP operations.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org