You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:48:29 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4077: Disable searching by instance name for customers
ravening opened a new pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077
## Description
Only admins should be able to search VM by instance name
Customers should not see or serach VM's using the instance name (i-)
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Login as "admin".
Note down the i- name of the customer VM.
Now login to the customer domain
Try to search for VM using the i- name
It should not display the VM. It should display only for admin
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-638558384
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-630074178
@DaanHoogland @andrijapanicsb yes I will add a global setting so that users can enable/disable it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-628478505
I appriciate that you considder this an enhancement/bug fix for your site @ravening , but I'm not convinced that this is true for every site. For instance a corporate cloud used in internal development might rely in their automation on instance names. Can you guard this with a setting allowing operators to let users search in the old fashion if they so wish?
cc @PaulAngus @rhtyd @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-642574168
ok @rhtyd @ravening I'm fine, i hadn't thought of instancename vs name. let's merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-640365976
Business layer only change, Travis/smoketests are enough I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-628481554
As long as the customer can not search instances by i-xxx-yy-vm name that are OUTSIDE of his domain, I don't see an issue here? Optionally, this should be configurable by a global setting, with defaulting to the current behaviour (unless there is some security concern which I did not read here?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-638558632
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-640320958
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-642593477
Checked and reported a bug in listVirtualMachinesMetrics API - https://github.com/apache/cloudstack/issues/4143
This PR is okay, let's merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-641329322
Overall LGTM, but have not tested it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-640337780
Packaging result: ✔centos7 ✖debian. JID-1306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-638558035
No need @ravening - PR LGTM
@DaanHoogland @andrijapanicsb I checked the API response we don't return the `instancename` to the user as part of the API response, so we can safely assume that end users wouldn't know the internal name of the VM. In case of admins, this is returned such as:
```
"instancename": "i-2-94-QA",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-642589641
Wait - please HOLD on merging - I probably found a regression, need to check something. Let me back on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-638583122
Packaging result: ✖centos7 ✖debian. JID-1279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-642589641
Wait - please HOLD on merging - I probably found a regression, need to check something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4077: Disable searching by instance name for customers
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-640320792
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org