You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/11/07 17:49:18 UTC
[GitHub] [nifi] mattyb149 edited a comment on issue #3874: NIFI-6842 -
Introduce MetricsEventReportingTask
mattyb149 edited a comment on issue #3874: NIFI-6842 - Introduce MetricsEventReportingTask
URL: https://github.com/apache/nifi/pull/3874#issuecomment-551187935
Looking good, made one doc-related comment. Also this might be a good time to change `test_nifi_rules.yml` and its associated `TestEasyRulesEngineService.testYamlNiFiRules()` test, the rule fires when backpressure is predicted to be more than 5 mins, not less. The condition should probably be `predictedTimeToBytesBackpressureMillis > 0 && predictedTimeToBytesBackpressureMillis < 300000` and the unit test should test for a value in that range. Looks like `TestRulesFactory.confirmEntries()` would have to be updated as well, for the changed condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services