You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/03 00:32:17 UTC
[GitHub] [incubator-superset] rusackas commented on issue #9207: Introducing
Inter UI & Fira typefaces
rusackas commented on issue #9207: Introducing Inter UI & Fira typefaces
URL: https://github.com/apache/incubator-superset/pull/9207#issuecomment-593704224
@etr2460 I shared this concern as I was implementing this... in fact I went down a rabbit hole of writing LESS conditional mixins to only load the `@font-face`s that were actually in use. In the end though, it turns out every browser since IE8 is smart enough to NOT load `@font-face` resources that aren't actually in use. So, I added all the font binaries to the repo in case they come in handy, but in actuality, only three of the weights, and one of the formats, might ever actually get loaded. Usually only a couple of those are actually in use by a given view, and they do appear to be cached from what I saw. So despite all the font binaries visible in this PR, the burden on load is actually pretty light.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org