[jira] [Comment Edited] (LUCENE-8343) BlendedInfixSuggester bad score calculus for certain suggestion weights

["Alessandro Benedetti (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561918#comment-16561918 ] 

Alessandro Benedetti edited comment on LUCENE-8343 at 7/30/18 1:25 PM:
-----------------------------------------------------------------------

Hi [~mikemccand], I just updated the Pull Request and patch.

I have checked ant precommit ant it seems fine to me.
 I have also executed some of the tests ( the one that are related with the Suggesters).
 There were some Solr tests failing. So I addressed that as well.
 let me know, happy to take care of anything that is missing.
i will monitor the Jira issue and check when the robot returns the checks and tests.


was (Author: alessandro.benedetti):
Hi [~mikemccand], I just updated the Pull Request and patch.

I have checked ant precommit ant it seems fine to me.
I have also executed some of the tests ( the one that are related with the Suggesters).
There were some Solr tests failing. So I addressed that as well.
let me know, happy to take care of anything that is missing.

> BlendedInfixSuggester bad score calculus for certain suggestion weights
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-8343
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8343
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 7.3.1
>            Reporter: Alessandro Benedetti
>            Priority: Major
>         Attachments: LUCENE-8343.patch, LUCENE-8343.patch, LUCENE-8343.patch, LUCENE-8343.patch, LUCENE-8343.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently the BlendedInfixSuggester return a (long) score to rank the suggestions.
> This score is calculated as a multiplication between :
> long *Weight* : the suggestion weight, coming from a document field, it can be any long value ( including 1, 0,.. )
> double *Coefficient* : 0<=x<=1, calculated based on the position match, earlier the better
> The resulting score is a long, which means that at the moment, any weight<10 can bring inconsistencies.
> *Edge cases* 
> Weight =1
> Score = 1( if we have a match at the beginning of the suggestion) or 0 ( for any other match)
> Weight =0
> Score = 0 ( independently of the position match coefficient)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org