You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "xy2953396112 (via GitHub)" <gi...@apache.org> on 2025/11/22 04:22:22 UTC
[PR] [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs… [celeborn]
xy2953396112 opened a new pull request, #3547:
URL: https://github.com/apache/celeborn/pull/3547
…, support setting the Buffer for fileInfo.
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
When a flushBuffer consolidation OOM exception occurs, support setting the Buffer for fileInfo.
### Why are the changes needed?
When a flushBuffer consolidation OOM exception occurs, the current logic does not allow setting the Buffer for fileInfo.
### Does this PR resolve a correctness bug?
NO
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs… [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on PR #3547:
URL: https://github.com/apache/celeborn/pull/3547#issuecomment-3621835490
@TheodoreLx Please help review this PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs… [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on code in PR #3547:
URL: https://github.com/apache/celeborn/pull/3547#discussion_r2596171629
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala:
##########
@@ -341,8 +341,18 @@ class MemoryTierWriter(
}
override def closeStreams(): Unit = {
- flushBuffer.consolidate()
- fileInfo.setBuffer(flushBuffer)
+ try {
+ flushBuffer.consolidate()
Review Comment:
Even if the `consolidate()` method fails, the `flushBuffer` object itself remains valid.When `CompositeByteBuf ` encounters an `OutOfMemoryError`, it will not be corrupted; only the memory `consolidation operation` fails to complete. Thus, although the `consolidate()` operation itself fails, the data integrity of flushBuffer is guaranteed, and it can be safely used continuously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs… [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on code in PR #3547:
URL: https://github.com/apache/celeborn/pull/3547#discussion_r2596171629
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala:
##########
@@ -341,8 +341,18 @@ class MemoryTierWriter(
}
override def closeStreams(): Unit = {
- flushBuffer.consolidate()
- fileInfo.setBuffer(flushBuffer)
+ try {
+ flushBuffer.consolidate()
Review Comment:
Even if the `consolidate()` method fails, the `flushBuffer` object itself remains valid.When `CompositeByteBuf ` encounters an `OutOfMemoryError`, it will not be corrupted; only the memory `consolidation operation` fails to complete. the data integrity of flushBuffer is guaranteed, and it can be safely used continuously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs… [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #3547:
URL: https://github.com/apache/celeborn/pull/3547#discussion_r2592844215
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala:
##########
@@ -341,8 +341,18 @@ class MemoryTierWriter(
}
override def closeStreams(): Unit = {
- flushBuffer.consolidate()
- fileInfo.setBuffer(flushBuffer)
+ try {
+ flushBuffer.consolidate()
Review Comment:
Is flushBuffer safe when call consolidate encounter OutOfMemoryError?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs… [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #3547:
URL: https://github.com/apache/celeborn/pull/3547#issuecomment-3705191866
Thanks. merge to main(v0.7.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs… [celeborn]
Posted by "TheodoreLx (via GitHub)" <gi...@apache.org>.
TheodoreLx commented on code in PR #3547:
URL: https://github.com/apache/celeborn/pull/3547#discussion_r2597849868
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala:
##########
@@ -341,8 +341,18 @@ class MemoryTierWriter(
}
override def closeStreams(): Unit = {
- flushBuffer.consolidate()
- fileInfo.setBuffer(flushBuffer)
+ try {
+ flushBuffer.consolidate()
Review Comment:
An OutOfMemoryError exception only occurs when the `allocBuffer` method is called in `CompositeByteBuf#consolidate0`. Before this, the internal data structure of `CompositeByteBuf` has not been modified, so even if `consolidate` throws an exception, the original buffer can still be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs… [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #3547: [CELEBORN-2210] When a flushBuffer consolidation OOM exception occurs…
URL: https://github.com/apache/celeborn/pull/3547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org