You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Paul Rogers (Code Review)" <ge...@cloudera.org> on 2019/02/23 04:00:15 UTC

[Impala-ASF-CR] IMPALA-8069: Crash in impala::Sorter::Run::Run

Hello Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12562

to look at the new patch set (#2).

Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run
......................................................................

IMPALA-8069: Crash in impala::Sorter::Run::Run

Modifies the planner to omit a sorter node in the obscure case we have
an analytic query with a constant sort. The analytic node requires a
buffered tuple. When the sort is omitted, creates a buffered tuple on
top of the node that would have been input to the sort.

Testing: added a new PlannerTest case for this case. Reran the query
that previously crashed: it now produces proper results.

Change-Id: I19a57f3791ce9e41fe0ba79dc5834e762341c74e
---
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/order.test
3 files changed, 32 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/12562/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19a57f3791ce9e41fe0ba79dc5834e762341c74e
Gerrit-Change-Number: 12562
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>