[commit] Selection gesture no longer produces redundant selection events

[Bill Haneman <bi...@ireland.sun.com>]

I have changed text selection (and selection in general) so that
redundant selection change events are not created.

Selector's selectTo() method now returns a boolean which indicates
whether
the result of te selectTo action is expected to change the current
selection (it's conservative, so it may be that the actual current
selection's content is unchanged even if selectTo returns true,
but if selectTo returns false, one can be assured that the selection 
has not changed as a result of the action).

The text node's implementation now returns true 
(in general) only when the character index resulting 
from a selection gesture has changed.

-Bill

-- 
--------------
Bill Haneman
+1 353 1 849 0495

Re: [commit] Selection gesture no longer produces redundant selection events

[Bill Haneman <bi...@ireland.sun.com>]

Stephane Hillion wrote:
<...>

By the way - your email only appeared in my mailbox 5 minutes ago
(>1 hour after being sent).  In the future if you find something
urgent, it's probably best to CC the probable culprit :-)

-Bill

--------------
Bill Haneman
+1 353 1 849 0495

Re: [commit] Selection gesture no longer produces redundant selection events

[Bill Haneman <bi...@ireland.sun.com>]

Stephane Hillion wrote:
> 
> I cannot compile anymore:

Sorry... try it now.  

I didn't commit the new Selectable (as I'm sure you figured out).

That's what I get for trying to do a limited commit, I guess :-(

-Bill

-- 
--------------
Bill Haneman
+1 353 1 849 0495

Re: [commit] Selection gesture no longer produces redundant selection events

[Stephane Hillion <St...@sophia.inria.fr>]

I cannot compile anymore:

    [javac]
/0/koala/shillion/xml-batik/sources/org/apache/batik/refimpl/gvt/ConcreteTextNode.java:37:
selectAll(double,double,org.apache.batik.gvt.GraphicsNodeRenderContext)
in org.apache.batik.refimpl.gvt.ConcreteTextNode cannot implement
selectAll(double,double,org.apache.batik.gvt.GraphicsNodeRenderContext)
in org.apache.batik.gvt.Selectable; attempting to use incompatible
return type
    [javac] found   : boolean
    [javac] required: void
    [javac] public class ConcreteTextNode
    [javac]        ^
    [javac]
/0/koala/shillion/xml-batik/sources/org/apache/batik/refimpl/gvt/text/ConcreteTextSelector.java:155:
incompatible types
    [javac] found   : void
    [javac] required: boolean
    [javac]                     boolean result = ((Selectable)
source).selectTo(p.getX(), p.getY(),

[javac]
^
    [javac] 2 errors