You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/29 14:59:35 UTC
[GitHub] [nifi] tpalfy opened a new pull request #4368: NIFI-7586 Add socket-level timeout properties for CassandraSessionProvider
tpalfy opened a new pull request #4368:
URL: https://github.com/apache/nifi/pull/4368
https://issues.apache.org/jira/browse/NIFI-7586
In CassandraSesionProvider added properties to set socket-level read timeout and connect timeout. In QueryCassandra when writing flowfile to the sesion it's done on the raw OutputStream. Wrapped it in a BufferedOutputStream for better performance.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip edited a comment on pull request #4368: NIFI-7586 Add socket-level timeout properties for CassandraSessionProvider
Posted by GitBox <gi...@apache.org>.
turcsanyip edited a comment on pull request #4368:
URL: https://github.com/apache/nifi/pull/4368#issuecomment-651396020
After changing the timeouts, I get the following errors from QueryCassandra / PutCassandraQL:
```
ERROR [Timer-Driven Process Thread-10] o.a.n.p.cassandra.QueryCassandra QueryCassandra[id=01ad5a7c-0173-1000-7fb3-a34af5274655] No host in the Cassandra cluster can be contacted successfully to execute this query: com.datastax.driver.core.exceptions.NoHostAvailableException: All host(s) tried for query failed (no host was tried)
```
```
com.datastax.driver.core.exceptions.DriverInternalError: Unexpected exception thrown
```
Did it work for you?
Update:
Seems to be an old issue.
Can be replicated on the current master:
- set up QueryCassandra with CassandraSessionProvider and start them
- stop QueryCassandra
- disable CassandraSessionProvider
- enable CassandraSessionProvider (no config change needed)
- start QueryCassandra => error
The new properties look good to me and work properly.
Merging to master...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] tpalfy commented on pull request #4368: NIFI-7586 Add socket-level timeout properties for CassandraSessionProvider
Posted by GitBox <gi...@apache.org>.
tpalfy commented on pull request #4368:
URL: https://github.com/apache/nifi/pull/4368#issuecomment-651762708
@turcsanyip
Thanks for finding this. It turns out there's been a bug in CassandraSessionProvider for a long time now.
Not related to this change so I opened a new ticket and will fix it in a subsequent PR: https://issues.apache.org/jira/browse/NIFI-7590
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #4368: NIFI-7586 Add socket-level timeout properties for CassandraSessionProvider
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on pull request #4368:
URL: https://github.com/apache/nifi/pull/4368#issuecomment-651396020
After changing the timeouts, I get the following errors from QueryCassandra / PutCassandraQL:
```
ERROR [Timer-Driven Process Thread-10] o.a.n.p.cassandra.QueryCassandra QueryCassandra[id=01ad5a7c-0173-1000-7fb3-a34af5274655] No host in the Cassandra cluster can be contacted successfully to execute this query: com.datastax.driver.core.exceptions.NoHostAvailableException: All host(s) tried for query failed (no host was tried)
```
```
com.datastax.driver.core.exceptions.DriverInternalError: Unexpected exception thrown
```
Did it work for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4368: NIFI-7586 Add socket-level timeout properties for CassandraSessionProvider
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4368:
URL: https://github.com/apache/nifi/pull/4368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org