[jira] [Closed] (LUCENE-3782) An incomplete fix for the NPE bugs in Directory.java

["Adrien Grand (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrien Grand closed LUCENE-3782.
--------------------------------
    Resolution: Unresolved

Directory.java has changed a lot and this bug is not relevant anymore.

> An incomplete fix for the NPE bugs in Directory.java
> ----------------------------------------------------
>
>                 Key: LUCENE-3782
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3782
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/store
>    Affects Versions: 3.0
>            Reporter: Guangtai Liang
>            Priority: Critical
>              Labels: incomplete_fix, missing_fixes
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The fix revision 499089 was aimed to remove an NPE bug (LUCENE-773) on the value  of  "lockFactory " in the method "clearLock" of the file "/lucene/java/trunk/src/java/org/apache/lucene/store/Directory.java" , but it is incomplete. 
> Since the value  "lockFactory " could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods. 
> The buggy code locations the same fix needs to be applied at are as bellows: 
>  
> Line 106 of the methods "doc()" , and "freq": 
>           public Lock makeLock(String name) {
> [Line 106]      return lockFactory.makeLock(name);
>           }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org