You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/15 10:17:29 UTC
[GitHub] [incubator-shenyu] hgaol opened a new pull request, #3566: [ISSUE #3556] downgrade curator to ver 4.0.1 for bootstrap data sync
hgaol opened a new pull request, #3566:
URL: https://github.com/apache/incubator-shenyu/pull/3566
<!-- Describe your PR here; eg. Fixes #issueNo -->
Sub task for #3556 , task 3. I've already finished the code change in #3476 . So in this PR, I just do some change for the version in pom file. I've tested sofa example and it works well.
After finished all code changed, I'll clean the pom.
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #3566: [ISSUE #3556] downgrade curator to ver 4.0.1 for bootstrap data sync
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3566:
URL: https://github.com/apache/incubator-shenyu/pull/3566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] hgaol commented on a diff in pull request #3566: [ISSUE #3556] downgrade curator to ver 4.0.1 for bootstrap data sync
Posted by GitBox <gi...@apache.org>.
hgaol commented on code in PR #3566:
URL: https://github.com/apache/incubator-shenyu/pull/3566#discussion_r897803477
##########
shenyu-sync-data-center/shenyu-sync-data-zookeeper/pom.xml:
##########
@@ -25,6 +25,11 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>shenyu-sync-data-zookeeper</artifactId>
+ <properties>
+ <curator.version>4.0.1</curator.version>
Review Comment:
The version in parent pom is 5.2.1. There're many places using curator like mentioned in the ISSUE #3556 . I plan to fix them step by step and after fixed all of them. I'll move it in root pom and clean all the child pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on a diff in pull request #3566: [ISSUE #3556] downgrade curator to ver 4.0.1 for bootstrap data sync
Posted by GitBox <gi...@apache.org>.
yu199195 commented on code in PR #3566:
URL: https://github.com/apache/incubator-shenyu/pull/3566#discussion_r897801801
##########
shenyu-sync-data-center/shenyu-sync-data-zookeeper/pom.xml:
##########
@@ -25,6 +25,11 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>shenyu-sync-data-zookeeper</artifactId>
+ <properties>
+ <curator.version>4.0.1</curator.version>
Review Comment:
move this into parent pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] hgaol commented on a diff in pull request #3566: [ISSUE #3556] downgrade curator to ver 4.0.1 for bootstrap data sync
Posted by GitBox <gi...@apache.org>.
hgaol commented on code in PR #3566:
URL: https://github.com/apache/incubator-shenyu/pull/3566#discussion_r897827258
##########
shenyu-sync-data-center/shenyu-sync-data-zookeeper/pom.xml:
##########
@@ -25,6 +25,11 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>shenyu-sync-data-zookeeper</artifactId>
+ <properties>
+ <curator.version>4.0.1</curator.version>
Review Comment:
Or I can do them in one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3566: [ISSUE #3556] downgrade curator to ver 4.0.1 for bootstrap data sync
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3566:
URL: https://github.com/apache/incubator-shenyu/pull/3566#issuecomment-1156307892
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3566](https://codecov.io/gh/apache/incubator-shenyu/pull/3566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bef39c8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/ac0a1342fd4625de8f986a9d3d2f03242bfcee8e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ac0a134) will **decrease** coverage by `0.35%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3566 +/- ##
============================================
- Coverage 62.60% 62.24% -0.36%
+ Complexity 5569 5527 -42
============================================
Files 848 848
Lines 23460 23460
Branches 2132 2132
============================================
- Hits 14686 14603 -83
- Misses 7419 7499 +80
- Partials 1355 1358 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...plugin/logging/rocketmq/LoggingRocketMQPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvTG9nZ2luZ1JvY2tldE1RUGx1Z2luLmphdmE=) | `22.72% <0.00%> (-72.73%)` | :arrow_down: |
| [...gboot/sync/data/zookeeper/ZookeeperProperties.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItc3luYy1kYXRhLWNlbnRlci9zaGVueXUtc3ByaW5nLWJvb3Qtc3RhcnRlci1zeW5jLWRhdGEtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zeW5jL2RhdGEvem9va2VlcGVyL1pvb2tlZXBlclByb3BlcnRpZXMuamF2YQ==) | `0.00% <0.00%> (-52.64%)` | :arrow_down: |
| [...data/zookeeper/ZookeeperSyncDataConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItc3luYy1kYXRhLWNlbnRlci9zaGVueXUtc3ByaW5nLWJvb3Qtc3RhcnRlci1zeW5jLWRhdGEtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zeW5jL2RhdGEvem9va2VlcGVyL1pvb2tlZXBlclN5bmNEYXRhQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-38.47%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...ogging/rocketmq/body/LoggingServerHttpRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvYm9keS9Mb2dnaW5nU2VydmVySHR0cFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | :arrow_down: |
| [.../apache/shenyu/admin/model/dto/BatchCommonDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0JhdGNoQ29tbW9uRFRPLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoV2FycERUTy5qYXZh) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| [...org/apache/shenyu/admin/model/dto/AuthPathDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoRFRPLmphdmE=) | `58.82% <0.00%> (-5.89%)` | :arrow_down: |
| [...nyu/plugin/motan/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vdGFuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL21vdGFuL2NhY2hlL0FwcGxpY2F0aW9uQ29uZmlnQ2FjaGUuamF2YQ==) | `52.00% <0.00%> (-5.00%)` | :arrow_down: |
| [.../logging/rocketmq/utils/LogCollectConfigUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvdXRpbHMvTG9nQ29sbGVjdENvbmZpZ1V0aWxzLmphdmE=) | `71.11% <0.00%> (-4.45%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3566/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac0a134...bef39c8](https://codecov.io/gh/apache/incubator-shenyu/pull/3566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] hgaol commented on a diff in pull request #3566: [ISSUE #3556] downgrade curator to ver 4.0.1 for bootstrap data sync
Posted by GitBox <gi...@apache.org>.
hgaol commented on code in PR #3566:
URL: https://github.com/apache/incubator-shenyu/pull/3566#discussion_r897803477
##########
shenyu-sync-data-center/shenyu-sync-data-zookeeper/pom.xml:
##########
@@ -25,6 +25,11 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>shenyu-sync-data-zookeeper</artifactId>
+ <properties>
+ <curator.version>4.0.1</curator.version>
Review Comment:
The version in parent pom is 5.2.1. There're many places use curator like mentioned in the ISSUE #3556 . I plan to fix them step by step and after fixed all of them. I'll move it in root pom and clean all the child pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org