[GitHub] [superset] eschutho commented on a change in pull request #19051: fix: update Permissions for right nav

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #19051:
URL: https://github.com/apache/superset/pull/19051#discussion_r823095278



##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -63,6 +79,9 @@ const StyledAnchor = styled.a`
 
 const { SubMenu } = Menu;
 
+// stole this from findPermission.ts
+const ADMIN_ROLE_NAME = 'admin';

Review comment:
       do you want to export this from `findPermission.ts` so that if it changes there, it will change here, too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org