You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2023/01/06 15:23:02 UTC
[GitHub] [opennlp] atarora opened a new pull request, #485: OPENNLP-1135 : Removed support for OSGi
atarora opened a new pull request, #485:
URL: https://github.com/apache/opennlp/pull/485
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] atarora commented on pull request #485: OPENNLP-1135 : Removed support for OSGi
Posted by GitBox <gi...@apache.org>.
atarora commented on PR #485:
URL: https://github.com/apache/opennlp/pull/485#issuecomment-1373812866
I have kept the scope to add extensions open (although not too sure if its required anymore!)
Please review and provide comments. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] atarora commented on a diff in pull request #485: OPENNLP-1135 : Removed support for OSGi
Posted by GitBox <gi...@apache.org>.
atarora commented on code in PR #485:
URL: https://github.com/apache/opennlp/pull/485#discussion_r1064885393
##########
opennlp-tools/src/main/java/opennlp/tools/util/ext/ExtensionServiceKeys.java:
##########
@@ -17,11 +17,11 @@
package opennlp.tools.util.ext;
-public final class ExtensionServiceKeys {
+public class ExtensionServiceKeys {
Review Comment:
Thank you for review and comments!
It looks like the 'final' was part of recent change which is honestly missed as part of merge (not intentional).
I can happily add it back in :) if required , although as per my previous comment I wasn't even too sure if this class is needed anymore.
Commit to follow!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] atarora commented on pull request #485: OPENNLP-1135 : Removed support for OSGi
Posted by GitBox <gi...@apache.org>.
atarora commented on PR #485:
URL: https://github.com/apache/opennlp/pull/485#issuecomment-1373949757
Looks like ExtensionLoader has a lot of occurrences so is related ExtensionNotLoadedException.
ExtensionServiceKeys doesn't have any related usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] atarora commented on pull request #485: OPENNLP-1135 : Removed support for OSGi
Posted by GitBox <gi...@apache.org>.
atarora commented on PR #485:
URL: https://github.com/apache/opennlp/pull/485#issuecomment-1373782141
I am not sure if I understand the conflict. Can someone help ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] mawiesne commented on a diff in pull request #485: OPENNLP-1135 : Removed support for OSGi
Posted by GitBox <gi...@apache.org>.
mawiesne commented on code in PR #485:
URL: https://github.com/apache/opennlp/pull/485#discussion_r1064812250
##########
opennlp-tools/src/main/java/opennlp/tools/util/ext/ExtensionServiceKeys.java:
##########
@@ -17,11 +17,11 @@
package opennlp.tools.util.ext;
-public final class ExtensionServiceKeys {
+public class ExtensionServiceKeys {
Review Comment:
@atarora Could you shortly elaborate why this class should not be `final` any more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] mawiesne commented on a diff in pull request #485: OPENNLP-1135 : Removed support for OSGi
Posted by GitBox <gi...@apache.org>.
mawiesne commented on code in PR #485:
URL: https://github.com/apache/opennlp/pull/485#discussion_r1064812250
##########
opennlp-tools/src/main/java/opennlp/tools/util/ext/ExtensionServiceKeys.java:
##########
@@ -17,11 +17,11 @@
package opennlp.tools.util.ext;
-public final class ExtensionServiceKeys {
+public class ExtensionServiceKeys {
Review Comment:
@atarora Could you shortly elaborate why this class should not be `final` anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] jzonthemtn commented on pull request #485: OPENNLP-1135 : Removed support for OSGi
Posted by GitBox <gi...@apache.org>.
jzonthemtn commented on PR #485:
URL: https://github.com/apache/opennlp/pull/485#issuecomment-1373919655
Thanks @atarora!
I think the extensions stuff can all be removed. I don't think there is anything else using them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] jzonthemtn merged pull request #485: OPENNLP-1135 : Removed support for OSGi
Posted by GitBox <gi...@apache.org>.
jzonthemtn merged PR #485:
URL: https://github.com/apache/opennlp/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org