You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/03/28 19:49:46 UTC
[kudu-CR] docs: Add documentation for background tasks
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6501
Change subject: docs: Add documentation for background tasks
......................................................................
docs: Add documentation for background tasks
This patch adds a documentation page for background tasks. My primary
motivation was to document tablet history GC but it seemed that we had a
hole in our documentation concerning the maintenance manager and
background tasks in general, so I tried to document everything at once.
Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
---
A docs/background_tasks.adoc
M docs/support/jekyll-templates/document.html.erb
2 files changed, 103 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6501/1
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] docs: Add documentation for background tasks
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] docs: Add documentation for background tasks
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6501/3/docs/background_tasks.adoc
File docs/background_tasks.adoc:
PS3, Line 95: The metrics associated with this background task have the prefix
: `undo_delta_block`.
Useful, but inconsistent with the other ops. Can you provide their metric prefixes too? Or is tablet history GC unusual in some way?
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: Add documentation for background tasks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Will Berkeley, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6501
to look at the new patch set (#5).
Change subject: docs: Add documentation for background tasks
......................................................................
docs: Add documentation for background tasks
This patch adds a documentation page for background tasks. My primary
motivation was to document tablet history GC but it seemed that we had a
hole in our documentation concerning the maintenance manager and
background tasks in general, so I tried to document everything at once.
Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
---
A docs/background_tasks.adoc
M docs/support/jekyll-templates/document.html.erb
2 files changed, 105 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6501/5
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] docs: Add documentation for background tasks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6501
to look at the new patch set (#4).
Change subject: docs: Add documentation for background tasks
......................................................................
docs: Add documentation for background tasks
This patch adds a documentation page for background tasks. My primary
motivation was to document tablet history GC but it seemed that we had a
hole in our documentation concerning the maintenance manager and
background tasks in general, so I tried to document everything at once.
Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
---
A docs/background_tasks.adoc
M docs/support/jekyll-templates/document.html.erb
2 files changed, 106 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6501/4
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] docs: Add documentation for background tasks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6501/3/docs/background_tasks.adoc
File docs/background_tasks.adoc:
PS3, Line 95: The metrics associated with this background task have the prefix
: `undo_delta_block`.
> Useful, but inconsistent with the other ops. Can you provide their metric p
I thought this one was unusual based on a quick look but actually there are some things I can add so I'll do that.
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: Add documentation for background tasks
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: docs: Add documentation for background tasks
......................................................................
docs: Add documentation for background tasks
This patch adds a documentation page for background tasks. My primary
motivation was to document tablet history GC but it seemed that we had a
hole in our documentation concerning the maintenance manager and
background tasks in general, so I tried to document everything at once.
Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Reviewed-on: http://gerrit.cloudera.org:8080/6501
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Jean-Daniel Cryans <jd...@apache.org>
---
A docs/background_tasks.adoc
M docs/support/jekyll-templates/document.html.erb
2 files changed, 105 insertions(+), 1 deletion(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] docs: Add documentation for background tasks
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 5: Verified+1
Odd looking test failure but no way a docs changed caused it.
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] docs: Add documentation for background tasks
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/6501/1/docs/background_tasks.adoc
File docs/background_tasks.adoc:
PS1, Line 53: maintain
Maybe "maintain consistent"?
PS1, Line 66: Kudu maintains a write-ahead log (WAL) per tablet
Mention here that it's split up into discrete fixed-size segments, to add context for the next sentence.
Line 73: Sometimes, it may be desirable to keep more WAL segments then the minimum
While useful, most of this paragraph is somewhat out of scope of this doc.
Line 81: `--log_max_segments_to_retain`.
Not sure we should doc log_max_segments_to_retain as it's experimental. log_min_segments_to_retain is fair game though.
PS1, Line 85: MVCC (multiversion concurrency control)
Nit: reverse and place MVCC in parens.
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] docs: Add documentation for background tasks
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: Add documentation for background tasks
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6501/4/docs/background_tasks.adoc
File docs/background_tasks.adoc:
Line 94: In the future, we may allow this to be specified on a per-table basis.
I dont think the "in the future" line is appropriate for user-facing docs
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] docs: Add documentation for background tasks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/6501/1/docs/background_tasks.adoc
File docs/background_tasks.adoc:
PS1, Line 53: maintain
> Maybe "maintain consistent"?
Done
PS1, Line 66: Kudu maintains a write-ahead log (WAL) per tablet
> Mention here that it's split up into discrete fixed-size segments, to add c
Done
Line 73: Sometimes, it may be desirable to keep more WAL segments then the minimum
> While useful, most of this paragraph is somewhat out of scope of this doc.
I agree. Removed.
Line 81: `--log_max_segments_to_retain`.
> Not sure we should doc log_max_segments_to_retain as it's experimental. log
Yeah... this should probably go in some separate document related to consensus or troubleshooting. Removed this whole paragraph.
PS1, Line 85: MVCC (multiversion concurrency control)
> Nit: reverse and place MVCC in parens.
Done
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: Add documentation for background tasks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#2).
Change subject: docs: Add documentation for background tasks
......................................................................
docs: Add documentation for background tasks
This patch adds a documentation page for background tasks. My primary
motivation was to document tablet history GC but it seemed that we had a
hole in our documentation concerning the maintenance manager and
background tasks in general, so I tried to document everything at once.
Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
---
A docs/background_tasks.adoc
M docs/support/jekyll-templates/document.html.erb
2 files changed, 104 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6501/2
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] docs: Add documentation for background tasks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6501/4/docs/background_tasks.adoc
File docs/background_tasks.adoc:
PS4, Line 58: RowSets
> I'd say DiskRowSets here too.
Done
Line 94: In the future, we may allow this to be specified on a per-table basis.
> I dont think the "in the future" line is appropriate for user-facing docs
Done
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] docs: Add documentation for background tasks
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6501/4/docs/background_tasks.adoc
File docs/background_tasks.adoc:
PS4, Line 58: RowSets
I'd say DiskRowSets here too.
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] docs: Add documentation for background tasks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6501
to look at the new patch set (#3).
Change subject: docs: Add documentation for background tasks
......................................................................
docs: Add documentation for background tasks
This patch adds a documentation page for background tasks. My primary
motivation was to document tablet history GC but it seemed that we had a
hole in our documentation concerning the maintenance manager and
background tasks in general, so I tried to document everything at once.
Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
---
A docs/background_tasks.adoc
M docs/support/jekyll-templates/document.html.erb
2 files changed, 98 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6501/3
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] docs: Add documentation for background tasks
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: docs: Add documentation for background tasks
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b14e481fad60397bbefc071887b7507e7806d0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No