You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zipkin.apache.org by Jorge Quilcate <qu...@gmail.com> on 2019/04/25 15:06:14 UTC
[VOTE] Release Apache Zipkin Layout Factory (incubating) version
0.0.5
Hello Zipkin Community,
This is a call for vote to release Apache Zipkin Layout Factory (incubating) version 0.0.5.
The release candidates: https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/
Git tag for the release: https://github.com/apache/incubator-zipkin-layout-factory/tree/v0.0.5
Hash for the release tag: 23dbddb426b4113c4b8633808b9ff0df3454e201
Release Notes: https://github.com/apache/incubator-zipkin-layout-factory/releases/tag/v0.0.5
The artifacts have been signed with Key : 50D90C2C, which can be found in the keys file: https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS
Verification Hints:
For your convenience, the below includes detailed how-to on verifying a source release. Please note that this document is a work-in-progresshttps://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release
The vote will be open for at least 72 hours or until necessary number of votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Zipkin (Incubating) Team
---------------------------------------------------------------------
To unsubscribe, e-mail:dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail:dev-help@zipkin.apache.org
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by mck <mc...@semb.wever.org>.
> The vote will be open for at least 72 hours or until necessary number
> of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
+1
tagging, sha, dependencies, and code looks good.
built source artifact from scratch no problems.
(although one needs to know `./mnw install` is the command)
regards,
Mick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by Adrian Cole <ad...@gmail.com>.
+1 verified the following
[PASS] Source archive has expected name
[PASS] SHA512 checksum is correct
[PASS] Provided GPG key is in KEYS file
[PASS] GPG signature is valid, made with the provided key
[PASS] Base dir in archive has expected name
[PASS] Git tree at provided revision matches source archive
[PASS] No .gitignore-d files in source archive
[PASS] DISCLAIMER and NOTICE look good
[PASS] LICENSE looks good
[PASS] No binary files in the release
Thanks tons to a lot of awesome work by Zoltán at
https://github.com/openzipkin-contrib/apache-release-verification
On Fri, Apr 26, 2019 at 12:06 AM Jorge Quilcate
<qu...@gmail.com> wrote:
>
> Hello Zipkin Community,
>
> This is a call for vote to release Apache Zipkin Layout Factory (incubating) version 0.0.5.
>
> The release candidates: https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/
>
> Git tag for the release: https://github.com/apache/incubator-zipkin-layout-factory/tree/v0.0.5
>
> Hash for the release tag: 23dbddb426b4113c4b8633808b9ff0df3454e201
>
> Release Notes: https://github.com/apache/incubator-zipkin-layout-factory/releases/tag/v0.0.5
>
> The artifacts have been signed with Key : 50D90C2C, which can be found in the keys file: https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS
>
> Verification Hints:
> For your convenience, the below includes detailed how-to on verifying a source release. Please note that this document is a work-in-progresshttps://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release
>
> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Zipkin (Incubating) Team
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail:dev-help@zipkin.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version
0.0.5
Posted by Jorge Quilcate <qu...@gmail.com>.
Thanks for the additional checks Adrian and Sheng!
The vote has passed with 5x +1 and no other votes. Thanks for taking the time to participate!
Voting +1 were: Zoltan, Adrian, Tommy, Jose Carlos, and Mick.
I will continue the process by initiating the IPMC vote
Jorge.
On 4/29/19 11:41 AM, Adrian Cole wrote:
> I just double-checked the dist and looks like the rat excludes are
> there and mvn install works etc. I think an old commit possibly didn't
> work, but the commit on this release does. I think we are good to go.
>
> Thanks for looking closely! we definitely prefer to have things in a
> pass state by the time we go IPMC vote.
>
> Best,
> -a
>
> On Mon, Apr 29, 2019 at 5:24 PM Adrian Cole <ad...@gmail.com> wrote:
>> weird that should have made Jenkins fail.. rat itself is not critical unless it stops the build from working. rat is just another faulty tool we use
>>
>> On Mon, Apr 29, 2019, 4:39 PM Sheng Wu <wu...@gmail.com> wrote:
>>> Hi
>>>
>>> I noticed this release rat check fails. Because of the following files
>>> 1. DEPENDENCIES
>>> 2. README.adoc
>>> 3. src/main/resources/spring.factories
>>>
>>> This may be a block to release, but incubator may ask :) We could add
>>> header or set ignore in rat pom setting.
>>>
>>> Others check passed.
>>> - Sign checked
>>> - Compile, test
>>> - Header, NOTICE
>>> - DISCLAIMER
>>> - sha512 exists
>>>
>>> Sheng Wu 吴晟
>>>
>>> Apache SkyWalking, ShardingSphere, Zipkin
>>> Twitter, wusheng1108
>>>
>>>
>>> Tommy Ludwig <to...@apache.org> 于2019年4月29日周一 上午11:33写道：
>>>
>>>> +1
>>>>
>>>> I have run the following for verification:
>>>> docker run --rm -ti abesto/openzipkin-contrib-apache-release-verification
>>>> --project zipkin --module zipkin-layout-factory --version 0.0.5 --gpg-key
>>>> 50D90C2C --git-hash 23dbddb426b4113c4b8633808b9ff0df3454e201 --repo dev
>>>> --zipname-template
>>>> 'apache-{module}{dash_incubating}-{version}-source-release'
>>>> --github-reponame-template '{incubator_dash}{module}.git'
>>>>
>>>> [PASS] Source archive has expected name
>>>> [PASS] SHA512 checksum is correct
>>>> [PASS] Provided GPG key is in KEYS file
>>>> [PASS] GPG signature is valid, made with the provided key
>>>> [PASS] Base dir in archive has expected name
>>>> [PASS] Git tree at provided revision matches source archive
>>>> [PASS] No .gitignore-d files in source archive
>>>> [PASS] DISCLAIMER and NOTICE look good
>>>> [PASS] LICENSE looks good
>>>> [PASS] No binary files in the release
>>>>
>>>> I also checked that `mvn test` compiles and runs tests successfully.
>>>>
>>>> On 2019/04/25 23:54:17, Adrian Cole <ad...@gmail.com> wrote:
>>>>> Thanks for checking, Zoltan. I will comment on your question below.
>>>>>
>>>>>> Note: the artifact naming here was a bit confusing for me. We have one
>>>>>> extra "zipkin-" here compared to previously migrated projects. Compare
>>>> the
>>>>>> URL paths with brave-karaf:
>>>>>> *
>>>>>>
>>>> https://dist.apache.org/repos/dist/release/incubator/zipkin/brave-karaf/0.1.2/apache-zipkin-brave-karaf-incubating-0.1.2-source-release.zip
>>>>>> *
>>>>>>
>>>> https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/apache-zipkin-layout-factory-incubating-0.0.5-source-release.zip
>>>>>> The salient part is that at "incubator/zipkin/zipkin-layout-factory" we
>>>>>> here have an extra "zipkin-", compared to
>>>> "incubator/zipkin/brave-karaf".
>>>>>> Notice how the zip filenames still have the same pattern. This is a
>>>> minor
>>>>>> nit, but might be nice to fix for consistency. Feel free to tell me I'm
>>>>>> wrong due to some nuance of Java artifact naming conventions, and this
>>>>>> difference is actually intentional and correct.
>>>>> The files here are about zipkin, not brave. To make the convention be
>>>>> more impactful, we can consider what we do when we release zipkin :)
>>>>> It won't be perfectly aligned I mean. However, I do think that
>>>>> following the stripped policy (except zipkin's main repo) is probably
>>>>> fine and least surprising.. wdyt?
>>>>>
>>>>> regardless, we can rename the paths in SVN as they are still created
>>>>> manually anyway..
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
>>>>> For additional commands, e-mail: dev-help@zipkin.apache.org
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
>>>> For additional commands, e-mail: dev-help@zipkin.apache.org
>>>>
>>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail: dev-help@zipkin.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by Adrian Cole <ad...@gmail.com>.
I just double-checked the dist and looks like the rat excludes are
there and mvn install works etc. I think an old commit possibly didn't
work, but the commit on this release does. I think we are good to go.
Thanks for looking closely! we definitely prefer to have things in a
pass state by the time we go IPMC vote.
Best,
-a
On Mon, Apr 29, 2019 at 5:24 PM Adrian Cole <ad...@gmail.com> wrote:
>
> weird that should have made Jenkins fail.. rat itself is not critical unless it stops the build from working. rat is just another faulty tool we use
>
> On Mon, Apr 29, 2019, 4:39 PM Sheng Wu <wu...@gmail.com> wrote:
>>
>> Hi
>>
>> I noticed this release rat check fails. Because of the following files
>> 1. DEPENDENCIES
>> 2. README.adoc
>> 3. src/main/resources/spring.factories
>>
>> This may be a block to release, but incubator may ask :) We could add
>> header or set ignore in rat pom setting.
>>
>> Others check passed.
>> - Sign checked
>> - Compile, test
>> - Header, NOTICE
>> - DISCLAIMER
>> - sha512 exists
>>
>> Sheng Wu 吴晟
>>
>> Apache SkyWalking, ShardingSphere, Zipkin
>> Twitter, wusheng1108
>>
>>
>> Tommy Ludwig <to...@apache.org> 于2019年4月29日周一 上午11:33写道：
>>
>> > +1
>> >
>> > I have run the following for verification:
>> > docker run --rm -ti abesto/openzipkin-contrib-apache-release-verification
>> > --project zipkin --module zipkin-layout-factory --version 0.0.5 --gpg-key
>> > 50D90C2C --git-hash 23dbddb426b4113c4b8633808b9ff0df3454e201 --repo dev
>> > --zipname-template
>> > 'apache-{module}{dash_incubating}-{version}-source-release'
>> > --github-reponame-template '{incubator_dash}{module}.git'
>> >
>> > [PASS] Source archive has expected name
>> > [PASS] SHA512 checksum is correct
>> > [PASS] Provided GPG key is in KEYS file
>> > [PASS] GPG signature is valid, made with the provided key
>> > [PASS] Base dir in archive has expected name
>> > [PASS] Git tree at provided revision matches source archive
>> > [PASS] No .gitignore-d files in source archive
>> > [PASS] DISCLAIMER and NOTICE look good
>> > [PASS] LICENSE looks good
>> > [PASS] No binary files in the release
>> >
>> > I also checked that `mvn test` compiles and runs tests successfully.
>> >
>> > On 2019/04/25 23:54:17, Adrian Cole <ad...@gmail.com> wrote:
>> > > Thanks for checking, Zoltan. I will comment on your question below.
>> > >
>> > > > Note: the artifact naming here was a bit confusing for me. We have one
>> > > > extra "zipkin-" here compared to previously migrated projects. Compare
>> > the
>> > > > URL paths with brave-karaf:
>> > > > *
>> > > >
>> > https://dist.apache.org/repos/dist/release/incubator/zipkin/brave-karaf/0.1.2/apache-zipkin-brave-karaf-incubating-0.1.2-source-release.zip
>> > > > *
>> > > >
>> > https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/apache-zipkin-layout-factory-incubating-0.0.5-source-release.zip
>> > > >
>> > > > The salient part is that at "incubator/zipkin/zipkin-layout-factory" we
>> > > > here have an extra "zipkin-", compared to
>> > "incubator/zipkin/brave-karaf".
>> > > > Notice how the zip filenames still have the same pattern. This is a
>> > minor
>> > > > nit, but might be nice to fix for consistency. Feel free to tell me I'm
>> > > > wrong due to some nuance of Java artifact naming conventions, and this
>> > > > difference is actually intentional and correct.
>> > >
>> > > The files here are about zipkin, not brave. To make the convention be
>> > > more impactful, we can consider what we do when we release zipkin :)
>> > > It won't be perfectly aligned I mean. However, I do think that
>> > > following the stripped policy (except zipkin's main repo) is probably
>> > > fine and least surprising.. wdyt?
>> > >
>> > > regardless, we can rename the paths in SVN as they are still created
>> > > manually anyway..
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
>> > > For additional commands, e-mail: dev-help@zipkin.apache.org
>> > >
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
>> > For additional commands, e-mail: dev-help@zipkin.apache.org
>> >
>> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by Adrian Cole <ad...@gmail.com>.
weird that should have made Jenkins fail.. rat itself is not critical
unless it stops the build from working. rat is just another faulty tool we
use
On Mon, Apr 29, 2019, 4:39 PM Sheng Wu <wu...@gmail.com> wrote:
> Hi
>
> I noticed this release rat check fails. Because of the following files
> 1. DEPENDENCIES
> 2. README.adoc
> 3. src/main/resources/spring.factories
>
> This may be a block to release, but incubator may ask :) We could add
> header or set ignore in rat pom setting.
>
> Others check passed.
> - Sign checked
> - Compile, test
> - Header, NOTICE
> - DISCLAIMER
> - sha512 exists
>
> Sheng Wu 吴晟
>
> Apache SkyWalking, ShardingSphere, Zipkin
> Twitter, wusheng1108
>
>
> Tommy Ludwig <to...@apache.org> 于2019年4月29日周一 上午11:33写道：
>
> > +1
> >
> > I have run the following for verification:
> > docker run --rm -ti abesto/openzipkin-contrib-apache-release-verification
> > --project zipkin --module zipkin-layout-factory --version 0.0.5 --gpg-key
> > 50D90C2C --git-hash 23dbddb426b4113c4b8633808b9ff0df3454e201 --repo dev
> > --zipname-template
> > 'apache-{module}{dash_incubating}-{version}-source-release'
> > --github-reponame-template '{incubator_dash}{module}.git'
> >
> > [PASS] Source archive has expected name
> > [PASS] SHA512 checksum is correct
> > [PASS] Provided GPG key is in KEYS file
> > [PASS] GPG signature is valid, made with the provided key
> > [PASS] Base dir in archive has expected name
> > [PASS] Git tree at provided revision matches source archive
> > [PASS] No .gitignore-d files in source archive
> > [PASS] DISCLAIMER and NOTICE look good
> > [PASS] LICENSE looks good
> > [PASS] No binary files in the release
> >
> > I also checked that `mvn test` compiles and runs tests successfully.
> >
> > On 2019/04/25 23:54:17, Adrian Cole <ad...@gmail.com> wrote:
> > > Thanks for checking, Zoltan. I will comment on your question below.
> > >
> > > > Note: the artifact naming here was a bit confusing for me. We have
> one
> > > > extra "zipkin-" here compared to previously migrated projects.
> Compare
> > the
> > > > URL paths with brave-karaf:
> > > > *
> > > >
> >
> https://dist.apache.org/repos/dist/release/incubator/zipkin/brave-karaf/0.1.2/apache-zipkin-brave-karaf-incubating-0.1.2-source-release.zip
> > > > *
> > > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/apache-zipkin-layout-factory-incubating-0.0.5-source-release.zip
> > > >
> > > > The salient part is that at "incubator/zipkin/zipkin-layout-factory"
> we
> > > > here have an extra "zipkin-", compared to
> > "incubator/zipkin/brave-karaf".
> > > > Notice how the zip filenames still have the same pattern. This is a
> > minor
> > > > nit, but might be nice to fix for consistency. Feel free to tell me
> I'm
> > > > wrong due to some nuance of Java artifact naming conventions, and
> this
> > > > difference is actually intentional and correct.
> > >
> > > The files here are about zipkin, not brave. To make the convention be
> > > more impactful, we can consider what we do when we release zipkin :)
> > > It won't be perfectly aligned I mean. However, I do think that
> > > following the stripped policy (except zipkin's main repo) is probably
> > > fine and least surprising.. wdyt?
> > >
> > > regardless, we can rename the paths in SVN as they are still created
> > > manually anyway..
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> > > For additional commands, e-mail: dev-help@zipkin.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> > For additional commands, e-mail: dev-help@zipkin.apache.org
> >
> >
>
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by Sheng Wu <wu...@gmail.com>.
Hi
I noticed this release rat check fails. Because of the following files
1. DEPENDENCIES
2. README.adoc
3. src/main/resources/spring.factories
This may be a block to release, but incubator may ask :) We could add
header or set ignore in rat pom setting.
Others check passed.
- Sign checked
- Compile, test
- Header, NOTICE
- DISCLAIMER
- sha512 exists
Sheng Wu 吴晟
Apache SkyWalking, ShardingSphere, Zipkin
Twitter, wusheng1108
Tommy Ludwig <to...@apache.org> 于2019年4月29日周一 上午11:33写道：
> +1
>
> I have run the following for verification:
> docker run --rm -ti abesto/openzipkin-contrib-apache-release-verification
> --project zipkin --module zipkin-layout-factory --version 0.0.5 --gpg-key
> 50D90C2C --git-hash 23dbddb426b4113c4b8633808b9ff0df3454e201 --repo dev
> --zipname-template
> 'apache-{module}{dash_incubating}-{version}-source-release'
> --github-reponame-template '{incubator_dash}{module}.git'
>
> [PASS] Source archive has expected name
> [PASS] SHA512 checksum is correct
> [PASS] Provided GPG key is in KEYS file
> [PASS] GPG signature is valid, made with the provided key
> [PASS] Base dir in archive has expected name
> [PASS] Git tree at provided revision matches source archive
> [PASS] No .gitignore-d files in source archive
> [PASS] DISCLAIMER and NOTICE look good
> [PASS] LICENSE looks good
> [PASS] No binary files in the release
>
> I also checked that `mvn test` compiles and runs tests successfully.
>
> On 2019/04/25 23:54:17, Adrian Cole <ad...@gmail.com> wrote:
> > Thanks for checking, Zoltan. I will comment on your question below.
> >
> > > Note: the artifact naming here was a bit confusing for me. We have one
> > > extra "zipkin-" here compared to previously migrated projects. Compare
> the
> > > URL paths with brave-karaf:
> > > *
> > >
> https://dist.apache.org/repos/dist/release/incubator/zipkin/brave-karaf/0.1.2/apache-zipkin-brave-karaf-incubating-0.1.2-source-release.zip
> > > *
> > >
> https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/apache-zipkin-layout-factory-incubating-0.0.5-source-release.zip
> > >
> > > The salient part is that at "incubator/zipkin/zipkin-layout-factory" we
> > > here have an extra "zipkin-", compared to
> "incubator/zipkin/brave-karaf".
> > > Notice how the zip filenames still have the same pattern. This is a
> minor
> > > nit, but might be nice to fix for consistency. Feel free to tell me I'm
> > > wrong due to some nuance of Java artifact naming conventions, and this
> > > difference is actually intentional and correct.
> >
> > The files here are about zipkin, not brave. To make the convention be
> > more impactful, we can consider what we do when we release zipkin :)
> > It won't be perfectly aligned I mean. However, I do think that
> > following the stripped policy (except zipkin's main repo) is probably
> > fine and least surprising.. wdyt?
> >
> > regardless, we can rename the paths in SVN as they are still created
> > manually anyway..
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> > For additional commands, e-mail: dev-help@zipkin.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail: dev-help@zipkin.apache.org
>
>
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by José Carlos Chávez <jc...@gmail.com>.
+1 great work Jorge!
[PASS] Source archive has expected name.
[PASS] SHA512 checksum is correct.
[PASS] Provided GPG key is in KEYS file.
[PASS] GPG signature is valid, made with the provided key.
[PASS] Base dir in archive has expected name.
[PASS] Git tree at provided revision matches source archive.
[PASS] No .gitignore-d files in source archive.
[PASS] DISCLAIMER and NOTICE look good.
[PASS] LICENSE looks good.
José Carlos
man. 29. apr. 2019, 05:33 skrev Tommy Ludwig <to...@apache.org>:
> +1
>
> I have run the following for verification:
> docker run --rm -ti abesto/openzipkin-contrib-apache-release-verification
> --project zipkin --module zipkin-layout-factory --version 0.0.5 --gpg-key
> 50D90C2C --git-hash 23dbddb426b4113c4b8633808b9ff0df3454e201 --repo dev
> --zipname-template
> 'apache-{module}{dash_incubating}-{version}-source-release'
> --github-reponame-template '{incubator_dash}{module}.git'
>
> [PASS] Source archive has expected name
> [PASS] SHA512 checksum is correct
> [PASS] Provided GPG key is in KEYS file
> [PASS] GPG signature is valid, made with the provided key
> [PASS] Base dir in archive has expected name
> [PASS] Git tree at provided revision matches source archive
> [PASS] No .gitignore-d files in source archive
> [PASS] DISCLAIMER and NOTICE look good
> [PASS] LICENSE looks good
> [PASS] No binary files in the release
>
> I also checked that `mvn test` compiles and runs tests successfully.
>
> On 2019/04/25 23:54:17, Adrian Cole <ad...@gmail.com> wrote:
> > Thanks for checking, Zoltan. I will comment on your question below.
> >
> > > Note: the artifact naming here was a bit confusing for me. We have one
> > > extra "zipkin-" here compared to previously migrated projects. Compare
> the
> > > URL paths with brave-karaf:
> > > *
> > >
> https://dist.apache.org/repos/dist/release/incubator/zipkin/brave-karaf/0.1.2/apache-zipkin-brave-karaf-incubating-0.1.2-source-release.zip
> > > *
> > >
> https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/apache-zipkin-layout-factory-incubating-0.0.5-source-release.zip
> > >
> > > The salient part is that at "incubator/zipkin/zipkin-layout-factory" we
> > > here have an extra "zipkin-", compared to
> "incubator/zipkin/brave-karaf".
> > > Notice how the zip filenames still have the same pattern. This is a
> minor
> > > nit, but might be nice to fix for consistency. Feel free to tell me I'm
> > > wrong due to some nuance of Java artifact naming conventions, and this
> > > difference is actually intentional and correct.
> >
> > The files here are about zipkin, not brave. To make the convention be
> > more impactful, we can consider what we do when we release zipkin :)
> > It won't be perfectly aligned I mean. However, I do think that
> > following the stripped policy (except zipkin's main repo) is probably
> > fine and least surprising.. wdyt?
> >
> > regardless, we can rename the paths in SVN as they are still created
> > manually anyway..
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> > For additional commands, e-mail: dev-help@zipkin.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail: dev-help@zipkin.apache.org
>
>
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by Tommy Ludwig <to...@apache.org>.
+1
I have run the following for verification:
docker run --rm -ti abesto/openzipkin-contrib-apache-release-verification --project zipkin --module zipkin-layout-factory --version 0.0.5 --gpg-key 50D90C2C --git-hash 23dbddb426b4113c4b8633808b9ff0df3454e201 --repo dev --zipname-template 'apache-{module}{dash_incubating}-{version}-source-release' --github-reponame-template '{incubator_dash}{module}.git'
[PASS] Source archive has expected name
[PASS] SHA512 checksum is correct
[PASS] Provided GPG key is in KEYS file
[PASS] GPG signature is valid, made with the provided key
[PASS] Base dir in archive has expected name
[PASS] Git tree at provided revision matches source archive
[PASS] No .gitignore-d files in source archive
[PASS] DISCLAIMER and NOTICE look good
[PASS] LICENSE looks good
[PASS] No binary files in the release
I also checked that `mvn test` compiles and runs tests successfully.
On 2019/04/25 23:54:17, Adrian Cole <ad...@gmail.com> wrote:
> Thanks for checking, Zoltan. I will comment on your question below.
>
> > Note: the artifact naming here was a bit confusing for me. We have one
> > extra "zipkin-" here compared to previously migrated projects. Compare the
> > URL paths with brave-karaf:
> > *
> > https://dist.apache.org/repos/dist/release/incubator/zipkin/brave-karaf/0.1.2/apache-zipkin-brave-karaf-incubating-0.1.2-source-release.zip
> > *
> > https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/apache-zipkin-layout-factory-incubating-0.0.5-source-release.zip
> >
> > The salient part is that at "incubator/zipkin/zipkin-layout-factory" we
> > here have an extra "zipkin-", compared to "incubator/zipkin/brave-karaf".
> > Notice how the zip filenames still have the same pattern. This is a minor
> > nit, but might be nice to fix for consistency. Feel free to tell me I'm
> > wrong due to some nuance of Java artifact naming conventions, and this
> > difference is actually intentional and correct.
>
> The files here are about zipkin, not brave. To make the convention be
> more impactful, we can consider what we do when we release zipkin :)
> It won't be perfectly aligned I mean. However, I do think that
> following the stripped policy (except zipkin's main repo) is probably
> fine and least surprising.. wdyt?
>
> regardless, we can rename the paths in SVN as they are still created
> manually anyway..
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail: dev-help@zipkin.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by Adrian Cole <ad...@gmail.com>.
Thanks for checking, Zoltan. I will comment on your question below.
> Note: the artifact naming here was a bit confusing for me. We have one
> extra "zipkin-" here compared to previously migrated projects. Compare the
> URL paths with brave-karaf:
> *
> https://dist.apache.org/repos/dist/release/incubator/zipkin/brave-karaf/0.1.2/apache-zipkin-brave-karaf-incubating-0.1.2-source-release.zip
> *
> https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/apache-zipkin-layout-factory-incubating-0.0.5-source-release.zip
>
> The salient part is that at "incubator/zipkin/zipkin-layout-factory" we
> here have an extra "zipkin-", compared to "incubator/zipkin/brave-karaf".
> Notice how the zip filenames still have the same pattern. This is a minor
> nit, but might be nice to fix for consistency. Feel free to tell me I'm
> wrong due to some nuance of Java artifact naming conventions, and this
> difference is actually intentional and correct.
The files here are about zipkin, not brave. To make the convention be
more impactful, we can consider what we do when we release zipkin :)
It won't be perfectly aligned I mean. However, I do think that
following the stripped policy (except zipkin's main repo) is probably
fine and least surprising.. wdyt?
regardless, we can rename the paths in SVN as they are still created
manually anyway..
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org
Re: [VOTE] Release Apache Zipkin Layout Factory (incubating) version 0.0.5
Posted by Zoltán Nagy <ab...@apache.org>.
+1. Checked:
* Source archive has expected name
* SHA512 checksum is correct
* Provided GPG key is in KEYS file
* GPG signature is valid, made with the provided key
* Base dir in archive has expected name
* Git tree at provided revision matches source archive
* No .gitignore-d files in source archive
* DISCLAIMER and NOTICE look good
* LICENSE looks good
* No binary files in the release
Note: the artifact naming here was a bit confusing for me. We have one
extra "zipkin-" here compared to previously migrated projects. Compare the
URL paths with brave-karaf:
*
https://dist.apache.org/repos/dist/release/incubator/zipkin/brave-karaf/0.1.2/apache-zipkin-brave-karaf-incubating-0.1.2-source-release.zip
*
https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/apache-zipkin-layout-factory-incubating-0.0.5-source-release.zip
The salient part is that at "incubator/zipkin/zipkin-layout-factory" we
here have an extra "zipkin-", compared to "incubator/zipkin/brave-karaf".
Notice how the zip filenames still have the same pattern. This is a minor
nit, but might be nice to fix for consistency. Feel free to tell me I'm
wrong due to some nuance of Java artifact naming conventions, and this
difference is actually intentional and correct.
(For anyone using the release checker script, it gets confused by the same,
and
https://github.com/openzipkin-contrib/apache-release-verification/pull/17
prepares
it for this difference and provides an example of using it)
On Thu, Apr 25, 2019 at 4:06 PM Jorge Quilcate <qu...@gmail.com>
wrote:
> Hello Zipkin Community,
>
> This is a call for vote to release Apache Zipkin Layout Factory
> (incubating) version 0.0.5.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-layout-factory/0.0.5/
>
> Git tag for the release:
> https://github.com/apache/incubator-zipkin-layout-factory/tree/v0.0.5
>
> Hash for the release tag: 23dbddb426b4113c4b8633808b9ff0df3454e201
>
> Release Notes:
> https://github.com/apache/incubator-zipkin-layout-factory/releases/tag/v0.0.5
>
> The artifacts have been signed with Key : 50D90C2C, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS
>
> Verification Hints:
> For your convenience, the below includes detailed how-to on verifying a
> source release. Please note that this document is a work-in-progresshttps://
> cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Zipkin (Incubating) Team
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail:dev-help@zipkin.apache.org
>
>