You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/18 15:07:57 UTC

[GitHub] [nifi] mark-bathori commented on pull request #6659: NIFI-10812: Remove duplicate record template creation from Iceberg record converter

mark-bathori commented on PR #6659:
URL: https://github.com/apache/nifi/pull/6659#issuecomment-1320151206

   Thanks for the comment @mattyb149. The record template copy was left here from a previous implementation and by removing this unnecessary call it doesn’t change the functionality only improves the performance so I think unit testing this change doesn’t really make sense. The method is covered with already existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org