You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "graysonzeng (via GitHub)" <gi...@apache.org> on 2023/08/04 03:09:14 UTC
[GitHub] [pulsar] graysonzeng opened a new pull request, #20929: [improve][broker] Add bookkeeper DirectIO conf
graysonzeng opened a new pull request, #20929:
URL: https://github.com/apache/pulsar/pull/20929
### Motivation
Make the bookeeper DirectIO parameter active.
it is unable to write to the bookkeeper.conf configuration file When we want to enable the DirectIO using helm
### Modifications
add DirectIO entry logger configuration
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [x] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lifepuzzlefun commented on pull request #20929: [improve] Add bookkeeper DirectIO conf
Posted by "lifepuzzlefun (via GitHub)" <gi...@apache.org>.
lifepuzzlefun commented on PR #20929:
URL: https://github.com/apache/pulsar/pull/20929#issuecomment-1675683328
By the way you can enable these parameters in helm, just add PULSAR_PREFIX_dbxxxxxxx the startup script will read all env startwith PULSAR_PREFIX and append to file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #20929: [improve] Add bookkeeper DirectIO conf
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #20929:
URL: https://github.com/apache/pulsar/pull/20929#issuecomment-1665040218
Suppose we add configuration here. It would be nice to add this to the doc as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] Add bookkeeper DirectIO conf [pulsar]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20929:
URL: https://github.com/apache/pulsar/pull/20929#issuecomment-1758786541
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #20929: [improve] Add bookkeeper DirectIO conf
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #20929:
URL: https://github.com/apache/pulsar/pull/20929#issuecomment-1665040619
@hangc0276 Could you please help review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] graysonzeng commented on pull request #20929: [improve] Add bookkeeper DirectIO conf
Posted by "graysonzeng (via GitHub)" <gi...@apache.org>.
graysonzeng commented on PR #20929:
URL: https://github.com/apache/pulsar/pull/20929#issuecomment-1713291134
> By the way you can enable these parameters in helm, just add PULSAR_PREFIX_dbxxxxxxx the startup script will read all env startwith PULSAR_PREFIX and append to file.
thanks for reminding, @hangc0276 Could you help me review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org