[GitHub] [dubbo] HetaoWang commented on a change in pull request #9451: cluserter merger refine

[GitBox <gi...@apache.org>]

HetaoWang commented on a change in pull request #9451:
URL: https://github.com/apache/dubbo/pull/9451#discussion_r773931342



##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/merger/MergerFactory.java
##########
@@ -49,34 +56,51 @@ public void setScopeModel(ScopeModel scopeModel) {
             throw new IllegalArgumentException("returnType is null");
         }
 
-        Merger result;
-        if (returnType.isArray()) {
-            Class type = returnType.getComponentType();

Review comment:
       one question is why the parameter type of Merger.merge() must be array? If use returnType.getComponentType() in MergerFactory, other non-array types can not exist in MergerFactory. 
   for example int[] and int type can not both exist in MergerFactory. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org