[jira] [Commented] (AMQ-6214) JAAS bug that causes user group membership not reloaded dynamically when reload is true

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197432#comment-15197432 ] 

ASF subversion and git services commented on AMQ-6214:
------------------------------------------------------

Commit 2788bd55845d35ffb753f20ea1fee9711e85fe43 in activemq's branch refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=2788bd5 ]

https://issues.apache.org/jira/browse/AMQ-6214

Fixing ReloadableProperties so that the groups file will be properly
reloaded on file modification. Added a test to verify.

Thanks to Nanchang Yang for providing the fix.


> JAAS bug that causes user group membership not reloaded dynamically when reload is true
> ---------------------------------------------------------------------------------------
>
>                 Key: AMQ-6214
>                 URL: https://issues.apache.org/jira/browse/AMQ-6214
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: jaas
>    Affects Versions: 5.13.0, 5.13.2
>         Environment: Linux, Mac
>            Reporter: Nanchang Yang
>            Assignee: Christopher L. Shannon
>            Priority: Minor
>              Labels: easyfix
>         Attachments: ReloadableProperties.java, activemq.xml, groups.properties, login.config, users.properties
>
>
> There is a bug in JAAS that caused users group membership not dynamically loading at runtime. Specifically, when I used the org.apache.activemq.jaas.PropertiesLoginModule with reload=true, changes in user name and password were reflected in connections after the changes, but changes in group membership was not reloaded/picked up by new connections.
> The configuration of my broker xml and users.properties, groups.properties, as well as the login.config files are attached.  
> The problem was repeatable always.
> The cause of the problem was identified as the groups membership was cached and the cache was not cleared (reloaded) after the groups.properties file change.
> The fix is to add one line of code in the org.apache.activemq.jaas.ReloadableProperties.java class.
> The src code with the fix for org.apache.activemq.jaas.ReloadableProperties.java is attached in the ticket as well.
> Please verify the fix and merge this one line of code change in org.apache.activemq.jaas.ReloadableProperties.java class in src branches for 5.13.0 as I tested the problem with 5.13.0 only.  The fix should be carried forward and retroactively merged into previous versions as well.
> There is no negative impact on software or any noticeable impact on server performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)