You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/26 14:42:24 UTC
[GitHub] [accumulo] dlmarion opened a new pull request, #3047: Log the client address when FrameBuffer read or write methods return false
dlmarion opened a new pull request, #3047:
URL: https://github.com/apache/accumulo/pull/3047
When FrameBuffer read and write methods return false it MAY be due to an error. Log at trace level the client address that it was trying to read from or write to. This will allow the user to modify the log level at runtime when they are seeing FrameBuffer errors being logged to try and identify the client.
Closes #3042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005809607
##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
logger.accumulo.name = org.apache.accumulo
logger.accumulo.level = debug
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)
Review Comment:
I don't think we need to reference the issue, because it doesn't really help the user get more information at all about this. If you do provide a reference, though, might as well just provide a URL to the issue.
Also, I'm not sure we need to have these in here, commented out at all. This is one of many many possible trace logs that the user might be interested in, and I don't think we should comment them all out in the example log4j properties file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false
Posted by GitBox <gi...@apache.org>.
keith-turner commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005964762
##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
logger.accumulo.name = org.apache.accumulo
logger.accumulo.level = debug
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)
Review Comment:
> You mean as a task for a future release?
yeah, for a future release would be nice to get the log messages better organized and cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005961603
##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
logger.accumulo.name = org.apache.accumulo
logger.accumulo.level = debug
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)
Review Comment:
> I would like to move more logging to that package.
You mean as a task for a future release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #3047: Log the client address when FrameBuffer read or write methods return false
Posted by GitBox <gi...@apache.org>.
dlmarion merged PR #3047:
URL: https://github.com/apache/accumulo/pull/3047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005829979
##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
logger.accumulo.name = org.apache.accumulo
logger.accumulo.level = debug
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)
Review Comment:
> In general, I agree with this. The problem here is that the user has to read the source code to find out all the places where trace logging may be available. I guess the solution here is to just change the root log level to trace
That's kinda true of any log statement at any log level. But, I especially don't think this is a burden for trace level. I'm hoping this is going to be something that isn't going to be needed very often once we watch it and figure out what's going on for ourselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false
Posted by GitBox <gi...@apache.org>.
keith-turner commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005952162
##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
logger.accumulo.name = org.apache.accumulo
logger.accumulo.level = debug
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)
Review Comment:
> In general, I agree with this. The problem here is that the user has to read the source code to find out all the places where trace logging may be available.
The following package is the beginning of an attempt to centralize important logging in the source code and make it discoverable by users. I would like to move more logging to that package.
https://github.com/apache/accumulo/blob/main/core/src/main/java/org/apache/accumulo/core/logging/package-info.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005822577
##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
logger.accumulo.name = org.apache.accumulo
logger.accumulo.level = debug
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)
Review Comment:
> I don't think we need to reference the issue, because it doesn't really help the user get more information at all about this.
Doesn't it provide more context, for example the possibility that it could be something external to the Accumulo cluster that is just connecting to open ports and sending data?
> Also, I'm not sure we need to have these in here, commented out at all. This is one of many many possible trace logs that the user might be interested in, and I don't think we should comment them all out in the example log4j properties file.
In general, I agree with this. The problem here is that the user has to read the source code to find out all the places where trace logging may be available. I guess the solution here is to just change the root log level to `trace` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005824361
##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
logger.accumulo.name = org.apache.accumulo
logger.accumulo.level = debug
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)
Review Comment:
I'll revert the commit that changed this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org