You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/22 07:12:17 UTC
[GitHub] [incubator-superset] maloun96 opened a new pull request #12168: Refresh interval
maloun96 opened a new pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168
## SUMMARY
Transform RefreshModal to Typescript
## Test Plan:
Create new Dashboard
Click on 3 dots right
Click Set auto-refresh interval
## BEFORE / AFTER
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 64.24% -2.23%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 19118 -13491
+ Misses 16302 10639 -5663
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.24% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | | |
| [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | | |
| [...dashboard/util/logging/findTopLevelComponentIds.js](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZFRvcExldmVsQ29tcG9uZW50SWRzLmpz) | | |
| [...-frontend/src/dashboard/util/headerStyleOptions.ts](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2hlYWRlclN0eWxlT3B0aW9ucy50cw==) | | |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvTGFiZWwuc3Rvcmllcy50c3g=) | | |
| [.../src/dashboard/components/menu/PopoverDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvUG9wb3ZlckRyb3Bkb3duLmpzeA==) | | |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | | |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | | |
| ... and [500 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: Refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 64.24% -2.23%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 19118 -13491
+ Misses 16302 10639 -5663
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.24% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | | |
| [...frontend/src/components/ListView/Filters/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9pbmRleC50c3g=) | | |
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | | |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | | |
| [...erset-frontend/src/profile/components/UserInfo.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9Vc2VySW5mby50c3g=) | | |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | | |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | | |
| ... and [500 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: Refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.84%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 63.63% -2.85%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 18936 -13673
+ Misses 16302 10821 -5481
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [509 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: Refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 63.64% -2.84%
==========================================
Files 994 484 -510
Lines 49054 29742 -19312
Branches 4979 0 -4979
==========================================
- Hits 32609 18929 -13680
+ Misses 16302 10813 -5489
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.64% <ø> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [516 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: Refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 64.09% -2.38%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 19074 -13535
+ Misses 16302 10683 -5619
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.09% <ø> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | | |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | | |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
| [.../src/views/CRUD/alert/components/RecipientIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9SZWNpcGllbnRJY29uLnRzeA==) | | |
| ... and [505 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (9d53d24) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.78%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 63.68% -2.79%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 18952 -13657
+ Misses 16302 10805 -5497
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.68% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [...rontend/src/components/ListView/Filters/Search.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9TZWFyY2gudHN4) | | |
| ... and [507 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 64.24% -2.23%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 19118 -13491
+ Misses 16302 10639 -5663
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.24% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [...mponents/nativeFilters/FilterConfigurationLink.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlndXJhdGlvbkxpbmsudHN4) | | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | | |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | | |
| [.../dashboard/util/logging/findNonTabChildChartIds.js](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZE5vblRhYkNoaWxkQ2hhcnRJZHMuanM=) | | |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | | |
| [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0VzdGltYXRlUXVlcnlDb3N0QnV0dG9uLmpzeA==) | | |
| [...t-frontend/src/views/CRUD/data/query/QueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeUxpc3QudHN4) | | |
| [.../src/views/CRUD/alert/components/RecipientIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9SZWNpcGllbnRJY29uLnRzeA==) | | |
| ... and [500 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (9d53d24) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.81%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 63.65% -2.82%
==========================================
Files 994 484 -510
Lines 49054 29742 -19312
Branches 4979 0 -4979
==========================================
- Hits 32609 18933 -13676
+ Misses 16302 10809 -5493
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.65% <ø> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| ... and [517 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: Refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.78%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 63.68% -2.79%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 18952 -13657
+ Misses 16302 10805 -5497
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.68% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [...rontend/src/components/ListView/Filters/Search.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9TZWFyY2gudHN4) | | |
| ... and [507 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: Refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 64.24% -2.23%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 19118 -13491
+ Misses 16302 10639 -5663
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.24% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | | |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | | |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
| [.../src/views/CRUD/alert/components/RecipientIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9SZWNpcGllbnRJY29uLnRzeA==) | | |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | | |
| [superset-frontend/src/common/components/Fade.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0ZhZGUudHN4) | | |
| [...UD/data/components/SyntaxHighlighterCopy/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21wb25lbnRzL1N5bnRheEhpZ2hsaWdodGVyQ29weS9pbmRleC50c3g=) | | |
| ... and [500 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] maloun96 commented on pull request #12168: refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
maloun96 commented on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749398920
@etr2460 @rusackas @junlincc It was moved to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12168: Refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 63.60% -2.87%
==========================================
Files 994 484 -510
Lines 49054 29742 -19312
Branches 4979 0 -4979
==========================================
- Hits 32609 18918 -13691
+ Misses 16302 10824 -5478
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.60% <ø> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [520 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12168: Refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168#issuecomment-749391199
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=h1) Report
> Merging [#12168](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=desc) (84f6e63) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e2f676445b406ddc3793949154270ab7a533a0e7?el=desc) (e2f6764) will **decrease** coverage by `2.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12168 +/- ##
==========================================
- Coverage 66.47% 64.24% -2.24%
==========================================
Files 994 484 -510
Lines 49054 29757 -19297
Branches 4979 0 -4979
==========================================
- Hits 32609 19117 -13492
+ Misses 16302 10640 -5662
+ Partials 143 0 -143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.24% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/api/dataset.ts](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FwaS9kYXRhc2V0LnRz) | | |
| [...UD/data/components/SyntaxHighlighterCopy/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21wb25lbnRzL1N5bnRheEhpZ2hsaWdodGVyQ29weS9pbmRleC50c3g=) | | |
| [...rset-frontend/src/components/LastUpdated/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFzdFVwZGF0ZWQvaW5kZXgudHN4) | | |
| [...set-frontend/src/common/components/InfoTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwLnRzeA==) | | |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | | |
| [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | | |
| [...rontend/src/dashboard/containers/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/12168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=footer). Last update [e2f6764...9d53d24](https://codecov.io/gh/apache/incubator-superset/pull/12168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #12168: refactor: Refresh interval typescript
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12168:
URL: https://github.com/apache/incubator-superset/pull/12168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org