You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/11 20:06:56 UTC

[GitHub] [incubator-superset] eschutho opened a new pull request #10847: update port that cypress runs on for local vs test

eschutho opened a new pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#discussion_r489012150



##########
File path: superset-frontend/cypress-base/package.json
##########
@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "description": "run cypress against superset",
   "scripts": {
-    "cypress": "cypress",
+    "cypress": "CYPRESS_BASE_URL=\"http://localhost:${npm_config_port:-8088}\" cypress",

Review comment:
       I think for `cypress open --port=8090`, the port is for Cypress itself, not the service it's testing against.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-692340483


   Thanks for the feedback on your process @ktmud. Would this change be helpful then if you didn't have to change your server config when you want to run cypress?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai merged pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=h1) Report
   > Merging [#10847](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3e2e65121fadc8ca507c490eb5a3b26d8153041?el=desc) will **decrease** coverage by `4.40%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10847/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10847      +/-   ##
   ==========================================
   - Coverage   65.42%   61.01%   -4.41%     
   ==========================================
     Files         804      809       +5     
     Lines       37942    38152     +210     
     Branches     3561     3605      +44     
   ==========================================
   - Hits        24823    23279    -1544     
   - Misses      13010    14687    +1677     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `60.67% <ø> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=footer). Last update [a3e2e65...2ddadd8](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691335072






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=h1) Report
   > Merging [#10847](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3e2e65121fadc8ca507c490eb5a3b26d8153041?el=desc) will **decrease** coverage by `4.44%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10847/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10847      +/-   ##
   ==========================================
   - Coverage   65.42%   60.98%   -4.45%     
   ==========================================
     Files         804      809       +5     
     Lines       37942    38152     +210     
     Branches     3561     3605      +44     
   ==========================================
   - Hits        24823    23266    -1557     
   - Misses      13010    14700    +1690     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `60.62% <ø> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=footer). Last update [a3e2e65...2ddadd8](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=h1) Report
   > Merging [#10847](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3e2e65121fadc8ca507c490eb5a3b26d8153041?el=desc) will **decrease** coverage by `4.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10847/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10847      +/-   ##
   ==========================================
   - Coverage   65.42%   61.16%   -4.27%     
   ==========================================
     Files         804      380     -424     
     Lines       37942    24068   -13874     
     Branches     3561        0    -3561     
   ==========================================
   - Hits        24823    14720   -10103     
   + Misses      13010     9348    -3662     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.16% <ø> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.05% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.46% <0.00%> (ø)` | |
   | [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | | |
   | [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | | |
   | [...et-frontend/src/dashboard/actions/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8uanM=) | | |
   | [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0VzdGltYXRlUXVlcnlDb3N0QnV0dG9uLmpzeA==) | | |
   | ... and [433 more](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=footer). Last update [a3e2e65...f85b804](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691335072






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691335072


   What I normally do change Superset's running port instead:
   
   ```
       {
         "label": "Flask Tests (8081)",
         "type": "shell",
         "command": "source activate superset && cd ${workspaceFolder} &&  ENABLE_REACT_CRUD_VIEWS=true SUPERSET_CONFIG=tests.superset_test_config_sqllab_backend_persist SUPERSET__SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@127.0.0.1:5432/superset_test flask run -p 8081 --no-debugger"
       },
       {
         "label": "Flask Tests (8088)",
         "type": "shell",
         "command": "source activate superset && cd ${workspaceFolder} && ENABLE_REACT_CRUD_VIEWS=true SUPERSET_CONFIG=tests.superset_test_config SUPERSET__SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@127.0.0.1:5432/superset_test flask run -p 8088 --no-debugger"
       },
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-693109646


   Cool, I agree the package.json was just syntactic sugar that would prevent someone from explicitly passing the env var when running the script and force them to pass the arg as defined instead. I removed that change. LMK if this feels better. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on a change in pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#discussion_r488257207



##########
File path: superset-frontend/cypress-base/package.json
##########
@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "description": "run cypress against superset",
   "scripts": {
-    "cypress": "cypress",
+    "cypress": "CYPRESS_BASE_URL=\"http://localhost:${npm_config_port:-8088}\" cypress",

Review comment:
       This isn't necessary, but an extra addition to potentially minimize confusion for engineers that have an existing cypress test workflow and aren't running on port 8088. You would overwrite the default with something like `npm run cypress open --port=8090`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691335072


   What I normally do is to change Superset's running port instead. I have the following two commands in `.vscode/tasks.json`:
   
   ```
       {
         "label": "Flask Tests (8081)",
         "type": "shell",
         "command": "source activate superset && cd ${workspaceFolder} &&  ENABLE_REACT_CRUD_VIEWS=true SUPERSET_CONFIG=tests.superset_test_config_sqllab_backend_persist SUPERSET__SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@127.0.0.1:5432/superset_test flask run -p 8081 --no-debugger"
       },
       {
         "label": "Flask Tests (8088)",
         "type": "shell",
         "command": "source activate superset && cd ${workspaceFolder} && ENABLE_REACT_CRUD_VIEWS=true SUPERSET_CONFIG=tests.superset_test_config SUPERSET__SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@127.0.0.1:5432/superset_test flask run -p 8088 --no-debugger"
       },
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691335072


   What I normally do is to change Superset's running port instead:
   
   ```
       {
         "label": "Flask Tests (8081)",
         "type": "shell",
         "command": "source activate superset && cd ${workspaceFolder} &&  ENABLE_REACT_CRUD_VIEWS=true SUPERSET_CONFIG=tests.superset_test_config_sqllab_backend_persist SUPERSET__SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@127.0.0.1:5432/superset_test flask run -p 8081 --no-debugger"
       },
       {
         "label": "Flask Tests (8088)",
         "type": "shell",
         "command": "source activate superset && cd ${workspaceFolder} && ENABLE_REACT_CRUD_VIEWS=true SUPERSET_CONFIG=tests.superset_test_config SUPERSET__SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@127.0.0.1:5432/superset_test flask run -p 8088 --no-debugger"
       },
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-693004920


   I agree it'd be very beneficial to make sure the default ports are consistent across places. I'm on board with changing the default port for Cypress if that means more consistency with Docker, default Flask port, `npm run dev-server` and anywhere else mentioned in the document.
   
   Yeah, I agree setting the port closer to the CI script makes things less brittle, which is why I feel it's probably not necessary to set `CYPRESS_BASE_URL` in `package.json`. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-693004920


   I agree it'd be very beneficial to make sure the default ports are consistent across places. I'm on board with changing the default port for Cypress if that means more consistency with Docker, default Flask port, `npm run dev-server` and anywhere else mentioned in the document.
   
   Yeah, I agree setting the port closer to the CI script makes things less brittle, which is why I feel it's probably not necessary to set `CYPRESS_BASE_URL` in `package.json`.  Other than that, I think changes in `cypress_build.sh` and `.github/workflows/bashlib.sh` both looks good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691335072


   What I normally do is to change Superset's running port instead. I have the following two commands in `.vscode/tasks.json`:
   
   ```
       {
         "label": "Flask Tests (8081)",
         "type": "shell",
         "command": "source activate superset && cd ${workspaceFolder} &&  ENABLE_REACT_CRUD_VIEWS=true SUPERSET_CONFIG=tests.superset_test_config SUPERSET__SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@127.0.0.1:5432/superset_test flask run -p 8081 --no-debugger"
       },
       {
         "label": "Flask Tests (8088)",
         "type": "shell",
         "command": "source activate superset && cd ${workspaceFolder} && ENABLE_REACT_CRUD_VIEWS=true SUPERSET_CONFIG=tests.superset_test_config SUPERSET__SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@127.0.0.1:5432/superset_test flask run -p 8088 --no-debugger"
       },
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on a change in pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#discussion_r488257894



##########
File path: superset-frontend/cypress-base/cypress.json
##########
@@ -1,5 +1,5 @@
 {
-  "baseUrl": "http://localhost:8081",
+  "baseUrl": "http://localhost:8088",

Review comment:
       just want to point out that this change could potentially break some user's workflow, but it could still be an improvement.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=h1) Report
   > Merging [#10847](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3e2e65121fadc8ca507c490eb5a3b26d8153041?el=desc) will **decrease** coverage by `4.44%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10847/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10847      +/-   ##
   ==========================================
   - Coverage   65.42%   60.98%   -4.45%     
   ==========================================
     Files         804      809       +5     
     Lines       37942    38152     +210     
     Branches     3561     3605      +44     
   ==========================================
   - Hits        24823    23266    -1557     
   - Misses      13010    14700    +1690     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `60.62% <ø> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=footer). Last update [a3e2e65...2ddadd8](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=h1) Report
   > Merging [#10847](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3e2e65121fadc8ca507c490eb5a3b26d8153041?el=desc) will **decrease** coverage by `4.40%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10847/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10847      +/-   ##
   ==========================================
   - Coverage   65.42%   61.01%   -4.41%     
   ==========================================
     Files         804      809       +5     
     Lines       37942    38152     +210     
     Branches     3561     3605      +44     
   ==========================================
   - Hits        24823    23279    -1544     
   - Misses      13010    14687    +1677     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `60.67% <ø> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=footer). Last update [a3e2e65...2ddadd8](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-692954636


   @ktmud yes, adding it to the docs would definitely reduce confusion. What do you feel about the extra task of setting the var each time to you run the npm script? Do you think the abstraction to have a default value preset, but still allowing a port override is helpful? I suppose some engs will resort to creating a bash alias if they use this script a lot and have to set the port each time. 
   
   Second question is around CI and tox.. I feel like setting the port closer in the script to where the port is set makes this less brittle, but curious to hear your thought on that, too.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on a change in pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#discussion_r489099027



##########
File path: superset-frontend/cypress-base/package.json
##########
@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "description": "run cypress against superset",
   "scripts": {
-    "cypress": "cypress",
+    "cypress": "CYPRESS_BASE_URL=\"http://localhost:${npm_config_port:-8088}\" cypress",

Review comment:
       Yes, correct, well, it's telling Cypress what url to test against, and would likely reconcile with the port that is exposed from however the flask app was started. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on a change in pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#discussion_r488257207



##########
File path: superset-frontend/cypress-base/package.json
##########
@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "description": "run cypress against superset",
   "scripts": {
-    "cypress": "cypress",
+    "cypress": "CYPRESS_BASE_URL=\"http://localhost:${npm_config_port:-8088}\" cypress",

Review comment:
       This isn't necessary, but an extra addition to potentially minimize confusion for engineers that have an existing cypress test workflow and aren't running on port 8088. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691335072






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=h1) Report
   > Merging [#10847](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3e2e65121fadc8ca507c490eb5a3b26d8153041?el=desc) will **decrease** coverage by `4.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10847/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10847      +/-   ##
   ==========================================
   - Coverage   65.42%   61.34%   -4.08%     
   ==========================================
     Files         804      380     -424     
     Lines       37942    24068   -13874     
     Branches     3561        0    -3561     
   ==========================================
   - Hits        24823    14765   -10058     
   + Misses      13010     9303    -3707     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.34% <ø> (+0.11%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.46% <0.00%> (ø)` | |
   | [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | | |
   | [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | | |
   | [superset-frontend/src/components/AvatarIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXZhdGFySWNvbi50c3g=) | | |
   | [...ontend/src/explore/controlPanels/Shared\_DeckGL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfRGVja0dMLmpzeA==) | | |
   | [...uperset-frontend/src/SqlLab/components/ShowSQL.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Nob3dTUUwudHN4) | | |
   | [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | | |
   | [...tend/src/dashboard/containers/FilterIndicators.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlckluZGljYXRvcnMuanN4) | | |
   | [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | | |
   | [...t-frontend/src/dashboard/util/setPeriodicRunner.ts](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NldFBlcmlvZGljUnVubmVyLnRz) | | |
   | ... and [428 more](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=footer). Last update [a3e2e65...f85b804](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691309120


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=h1) Report
   > Merging [#10847](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3e2e65121fadc8ca507c490eb5a3b26d8153041?el=desc) will **decrease** coverage by `5.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10847/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10847      +/-   ##
   ==========================================
   - Coverage   65.42%   59.57%   -5.85%     
   ==========================================
     Files         804      780      -24     
     Lines       37942    37203     -739     
     Branches     3561     3339     -222     
   ==========================================
   - Hits        24823    22164    -2659     
   - Misses      13010    14852    +1842     
   - Partials      109      187      +78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `56.12% <ø> (+0.75%)` | :arrow_up: |
   | #javascript | `?` | |
   | #python | `61.44% <ø> (+0.21%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
   | [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `8.33% <0.00%> (-85.42%)` | :arrow_down: |
   | ... and [293 more](https://codecov.io/gh/apache/incubator-superset/pull/10847/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=footer). Last update [a3e2e65...6e604b4](https://codecov.io/gh/apache/incubator-superset/pull/10847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-692349416


   I think the point of the `CYPRESS_BASE_URL` variable is that you can override it ad-hoc. It doesn't feel right to me to bake it into a fixed value in CI/NPM scripts. This would make it impossible to override it outside of the running script.
   
   Would adding instructions of how to set `CYPRESS_BASE_URL` to `CONTRIBUTING.md` or [docker/README.md](https://github.com/apache/incubator-superset/blob/master/docker/README.md) suffice to reduce confusions? 
   
   ```bash
   cd cypress-base
   CYPRESS_BASE_URL=http://localhost:8088 npm run cypress-debug
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10847: update port that cypress runs on for local vs test

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10847:
URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-691335072






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org