[jira] [Comment Edited] (AMBARI-22723) Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

["Dmitry Lysnichenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311569#comment-16311569 ] 

Dmitry Lysnichenko edited comment on AMBARI-22723 at 1/4/18 4:37 PM:
---------------------------------------------------------------------

Committed 
To https://git-wip-us.apache.org/repos/asf/ambari.git
   41c362eb97..b5da60b5ac  branch-2.6 -> branch-2.6
   c088e59ebc..dfb9785519  trunk -> trunk




was (Author: dmitriusan):
Committed 
To https://git-wip-us.apache.org/repos/asf/ambari.git
   41c362eb97..b5da60b5ac  branch-2.6 -> branch-2.6


> Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-22723
>                 URL: https://issues.apache.org/jira/browse/AMBARI-22723
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.6.1
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>            Priority: Blocker
>             Fix For: 2.6.2
>
>         Attachments: AMBARI-22723.patch
>
>
> AMBARI-21728 and AMBARI-22469 make the upgrade broken in case of several upgrade tries, failing to follow the Idempotent upgrade paradigm.
> Issue is with:
> {code}
> protected void executeDDLUpdates() throws AmbariException, SQLException {
> Integer currentVersionID = getCurrentVersionID();    <----------------------
> dropBrokenFK();
> updateServiceComponentDesiredStateTable(currentVersionID); <----------------------
> updateServiceDesiredStateTable(currentVersionID); <----------------------
> addSelectedCollumsToClusterconfigTable();
> updateHostComponentDesiredStateTable();
> updateHostComponentStateTable();
> dropStaleTables();  <----------------------
> updateUpgradeTable();
> createUpgradeHistoryTable();
> updateRepositoryVersionTable();
> renameServiceDeletedColumn();
> addLegacyColumn();
> expandUpgradeItemItemTextColumn();
> addViewUrlPKConstraint();
> removeStaleConstraints();
> }
> {code}
> {{getCurrentVersionID()}} trying to query non-existing table and failing whole upgrade



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)