You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/05/11 10:02:16 UTC
[GitHub] [incubator-celeborn] zwangsheng opened a new pull request, #1484: [CELEBORN-105] DRAFT: Kubernetes Integration Test
zwangsheng opened a new pull request, #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Add Kubernetes Integration Test
- [x] test helm install deploy
- [ ] test shuffle
### Why are the changes needed?
Add integration test
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Ci test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214324553
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
+class DeploySuite extends CelebornFunSuite with WithMiniKube {
+ final val masterStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-master").get()
+ assert(masterStatefulSet != null)
+ final val workerStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-worker").get()
+ assert(workerStatefulSet != null)
+
+ test("Check master started") {
+ val masterPod = kubernetesClient.pods().withName("celeborn-master-0")
+ // wait master start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
Review Comment:
can we shorten the interval?
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
+class DeploySuite extends CelebornFunSuite with WithMiniKube {
+ final val masterStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-master").get()
+ assert(masterStatefulSet != null)
+ final val workerStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-worker").get()
+ assert(workerStatefulSet != null)
+
+ test("Check master started") {
+ val masterPod = kubernetesClient.pods().withName("celeborn-master-0")
+ // wait master start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
+ val log =
+ masterPod.getLog(true)
+ assert(log.contains("Master started."))
+ }
+
+ assert(masterPod.get().getStatus.getPhase == "Running")
+ }
+
+ test("Check worker started") {
+ val workerPod = kubernetesClient.pods().withName("celeborn-worker-0")
+ // wait worker start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
+ val log =
+ workerPod.getLog(true)
Review Comment:
```suggestion
val log = workerPod.getLog(true)
```
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
+class DeploySuite extends CelebornFunSuite with WithMiniKube {
+ final val masterStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-master").get()
+ assert(masterStatefulSet != null)
+ final val workerStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-worker").get()
+ assert(workerStatefulSet != null)
+
+ test("Check master started") {
+ val masterPod = kubernetesClient.pods().withName("celeborn-master-0")
+ // wait master start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
+ val log =
+ masterPod.getLog(true)
+ assert(log.contains("Master started."))
+ }
+
+ assert(masterPod.get().getStatus.getPhase == "Running")
+ }
+
+ test("Check worker started") {
+ val workerPod = kubernetesClient.pods().withName("celeborn-worker-0")
+ // wait worker start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214324284
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
+class DeploySuite extends CelebornFunSuite with WithMiniKube {
+ final val masterStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-master").get()
+ assert(masterStatefulSet != null)
+ final val workerStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-worker").get()
+ assert(workerStatefulSet != null)
+
+ test("Check master started") {
+ val masterPod = kubernetesClient.pods().withName("celeborn-master-0")
+ // wait master start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
+ val log =
+ masterPod.getLog(true)
Review Comment:
```suggestion
val log = masterPod.getLog(true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214330063
##########
.github/workflows/integration.yml:
##########
@@ -0,0 +1,73 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Integration Test
+
+on:
+ push:
+ branches:
+ - main
+ - branch-*
+ pull_request:
+ branches:
+ - main
+ - branch-*
+
+jobs:
+ celeborn_integration_test:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-java@v2
+ name: Setup JDK with Maven
+ with:
+ distribution: zulu
+ java-version: 8
+ cache: maven
+ check-latest: false
+ - name: Build Celeborn Binary
+ run:
+ ./build/make-distribution.sh -Pspark-3.3 -Pgoogle-mirror
+ - name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v1
+ - name: Build Celeborn Docker Image
+ uses: docker/build-push-action@v2
+ with:
+ context: ./dist
+ file: ./docker/Dockerfile
+ load: true
+ tags: apache/celeborn:latest
+ - name: Setup Helm
+ uses: azure/setup-helm@v3
+ with:
+ version: v3.10.0
+ - name: Setup Minikube
+ uses: manusa/actions-setup-minikube@v2.7.1
Review Comment:
this plugin was found some issues in the Kyuubi community, eventually, we decided to download minikube binary directly, same suggestion here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214332729
##########
pom.xml:
##########
@@ -90,6 +90,7 @@
<roaringbitmap.version>0.9.32</roaringbitmap.version>
<snakeyaml.version>1.33</snakeyaml.version>
<zstd-jni.version>1.5.2-1</zstd-jni.version>
+ <kubernetes-client.version>6.3.1</kubernetes-client.version>
Review Comment:
let's use the latest one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1484: [CELEBORN-105] DRAFT: Kubernetes Integration Test
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#issuecomment-1543721435
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1484?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1484](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1484?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7c62fb) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/5769c3fdc7eebd7701c40be364c83374ff7ea03b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5769c3f) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
- Coverage 45.02% 45.01% -0.01%
==========================================
Files 158 158
Lines 9678 9678
Branches 957 957
==========================================
- Hits 4357 4356 -1
Misses 5034 5034
- Partials 287 288 +1
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1484/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#issuecomment-1576015714
Thanks, merged to main for 0.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214327174
##########
tests/kubernetes-it/src/test/resources/log4j2-test.xml:
##########
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<Configuration status="INFO">
+ <Appenders>
+ <Console name="stdout" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
+ <Filters>
+ <ThresholdFilter level="FATAL"/>
+ </Filters>
+ </Console>
+ <File name="file" fileName="target/unit-tests.log">
Review Comment:
this looks for the IT module itself, but ideally, we should save and upload the pod logs in case we need to know what happened in the container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214322932
##########
tests/kubernetes-it/docker/helm/values.yaml:
##########
@@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+image:
+ repository: apache/celeborn
+ pullPolicy: IfNotPresent
+ tag: latest
+
+imagePullSecrets: {}
+
+# master replicas should not less than 3
+masterReplicas: 1
Review Comment:
the value violate the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214327174
##########
tests/kubernetes-it/src/test/resources/log4j2-test.xml:
##########
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<Configuration status="INFO">
+ <Appenders>
+ <Console name="stdout" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
+ <Filters>
+ <ThresholdFilter level="FATAL"/>
+ </Filters>
+ </Console>
+ <File name="file" fileName="target/unit-tests.log">
Review Comment:
this looks for the IT module itself, but ideally, we should save and upload the pod logs in case we need to know what happened in the container (this can be implemented as a follow-up PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214323357
##########
tests/kubernetes-it/docker/helm/values.yaml:
##########
@@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+image:
+ repository: apache/celeborn
+ pullPolicy: IfNotPresent
+ tag: latest
+
+imagePullSecrets: {}
+
+# master replicas should not less than 3
+masterReplicas: 1
+# worker replicas set on demand, should less than node number
+workerReplicas: 1
+
+securityContext:
+ fsGroup: 10006
+
+# Current Celeborn support followings volume type:
+# - emptyDir
+# - hostPath
+# Note: size only works in emptyDir type
+# Celeborn Master will pick first volumes for store raft log
+volumes:
+ master:
+ - path: /mnt/rss_ratis
Review Comment:
please rebase main branch and update the key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214323357
##########
tests/kubernetes-it/docker/helm/values.yaml:
##########
@@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+image:
+ repository: apache/celeborn
+ pullPolicy: IfNotPresent
+ tag: latest
+
+imagePullSecrets: {}
+
+# master replicas should not less than 3
+masterReplicas: 1
+# worker replicas set on demand, should less than node number
+workerReplicas: 1
+
+securityContext:
+ fsGroup: 10006
+
+# Current Celeborn support followings volume type:
+# - emptyDir
+# - hostPath
+# Note: size only works in emptyDir type
+# Celeborn Master will pick first volumes for store raft log
+volumes:
+ master:
+ - path: /mnt/rss_ratis
Review Comment:
please rebase main branch and update the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214324030
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
Review Comment:
```suggestion
// TODO need add shuffle client test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1484: [CELEBORN-105]Kubernetes Integration Test
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1212753275
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
Review Comment:
For now, we have to resolve original dns `pod_name + svc_name + namespace` to ip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214332150
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
+class DeploySuite extends CelebornFunSuite with WithMiniKube {
+ final val masterStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-master").get()
+ assert(masterStatefulSet != null)
+ final val workerStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-worker").get()
+ assert(workerStatefulSet != null)
+
+ test("Check master started") {
+ val masterPod = kubernetesClient.pods().withName("celeborn-master-0")
+ // wait master start
Review Comment:
```suggestion
// wait for master ready
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1217356115
##########
tests/kubernetes-it/src/test/resources/log4j2-test.xml:
##########
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<Configuration status="INFO">
+ <Appenders>
+ <Console name="stdout" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
+ <Filters>
+ <ThresholdFilter level="FATAL"/>
+ </Filters>
+ </Console>
+ <File name="file" fileName="target/unit-tests.log">
Review Comment:
Sure, in follow-up PR, we can use `Pod#getLog()` function to print container log in local file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1214339927
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
+class DeploySuite extends CelebornFunSuite with WithMiniKube {
+ final val masterStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-master").get()
+ assert(masterStatefulSet != null)
+ final val workerStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-worker").get()
+ assert(workerStatefulSet != null)
+
+ test("Check master started") {
+ val masterPod = kubernetesClient.pods().withName("celeborn-master-0")
+ // wait master start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
+ val log =
+ masterPod.getLog(true)
+ assert(log.contains("Master started."))
+ }
+
+ assert(masterPod.get().getStatus.getPhase == "Running")
+ }
+
+ test("Check worker started") {
+ val workerPod = kubernetesClient.pods().withName("celeborn-worker-0")
+ // wait worker start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
+ val log =
+ workerPod.getLog(true)
Review Comment:
wait, this does not mean the worker node is really ready, we need to add some logs to indicate the master/worker is ready for serving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#issuecomment-1573687310
@zwangsheng thanks for your efforts, this PR overall LGTM, left some minor comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #1484:
URL: https://github.com/apache/incubator-celeborn/pull/1484#discussion_r1217353968
##########
tests/kubernetes-it/src/test/scala/org.apache.celeborn.integration/DeploySuite.scala:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.integration
+
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually.eventually
+import org.scalatest.concurrent.Waiters.{interval, timeout}
+import org.scalatest.time.SpanSugar.convertIntToGrainOfTime
+
+import org.apache.celeborn.CelebornFunSuite
+import org.apache.celeborn.client.WithShuffleClientSuite
+
+//TODO need add shuffle client test
+class DeploySuite extends CelebornFunSuite with WithMiniKube {
+ final val masterStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-master").get()
+ assert(masterStatefulSet != null)
+ final val workerStatefulSet =
+ kubernetesClient.apps().statefulSets().withName("celeborn-worker").get()
+ assert(workerStatefulSet != null)
+
+ test("Check master started") {
+ val masterPod = kubernetesClient.pods().withName("celeborn-master-0")
+ // wait master start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
+ val log =
+ masterPod.getLog(true)
+ assert(log.contains("Master started."))
+ }
+
+ assert(masterPod.get().getStatus.getPhase == "Running")
+ }
+
+ test("Check worker started") {
+ val workerPod = kubernetesClient.pods().withName("celeborn-worker-0")
+ // wait worker start
+ eventually(timeout(5 minutes), interval(30 seconds)) {
+ val log =
+ workerPod.getLog(true)
Review Comment:
For now, `Master\Worker started.`, this type of log is the bottom log of start service and before `rpcEnv.awaitTermination()`.
Maybe this is enough for simple judge Master\Worker Started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1484: [CELEBORN-105][TEST] Kubernetes Integration Test
URL: https://github.com/apache/incubator-celeborn/pull/1484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org