You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/12/07 01:44:08 UTC

[jira] Created: (WHIRR-152) Add option to leave cluster running when integration tests fail

Add option to leave cluster running when integration tests fail
---------------------------------------------------------------

                 Key: WHIRR-152
                 URL: https://issues.apache.org/jira/browse/WHIRR-152
             Project: Whirr
          Issue Type: Improvement
          Components: core
            Reporter: Tom White


This would be useful for debugging why tests failed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-152) Add option to leave cluster running when integration tests fail

Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992295#comment-12992295 ] 

Adrian Cole commented on WHIRR-152:
-----------------------------------

I think this patch can work, but could be a bit cleaner.  For example, I think we should consider not tainting code with any references to test case state. An alternate way could be to manage this with clarifying the operations to include things like start/stopProxy and start/stopCluster vs create/destroyCluster.

In the mean time, I think a better way would be to check for a system property like whirr.don'tshutdownmystuff in the tearDown() method, and conditionally shut down there.

> Add option to leave cluster running when integration tests fail
> ---------------------------------------------------------------
>
>                 Key: WHIRR-152
>                 URL: https://issues.apache.org/jira/browse/WHIRR-152
>             Project: Whirr
>          Issue Type: Improvement
>          Components: core
>            Reporter: Tom White
>         Attachments: WHIRR-152.patch, WHIRR-152.patch
>
>
> This would be useful for debugging why tests failed.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WHIRR-152) Add option to leave cluster running when integration tests fail

Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Cole updated WHIRR-152:
------------------------------

    Attachment: WHIRR-152.patch

recut version of old patch

> Add option to leave cluster running when integration tests fail
> ---------------------------------------------------------------
>
>                 Key: WHIRR-152
>                 URL: https://issues.apache.org/jira/browse/WHIRR-152
>             Project: Whirr
>          Issue Type: Improvement
>          Components: core
>            Reporter: Tom White
>         Attachments: WHIRR-152.patch, WHIRR-152.patch
>
>
> This would be useful for debugging why tests failed.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WHIRR-152) Add option to leave cluster running when integration tests fail

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated WHIRR-152:
----------------------------

    Attachment: WHIRR-152.patch

Here's a partial patch for this (needs filling out for services other than Hadoop). Set the property whirr.test.keep-cluster-on-failure to true to leave the cluster running if the test fails. E.g.

{code}
mvn verify -Pintegration -DargLine="-Dwhirr.test.provider=ec2 -Dwhirr.test.identity=$AWS_ACCESS_KEY_ID -Dwhirr.test.credential=$AWS_SECRET_ACCESS_KEY -Dwhirr.test.keep-cluster-on-failure=true"
{code}

Shut it down later with the DestroyTestClusters test. E.g.

{code}
mvn verify -Pintegration -DargLine="-Dwhirr.test.provider=ec2 -Dwhirr.test.identity=$AWS_ACCESS_KEY_ID -Dwhirr.test.credential=$AWS_SECRET_ACCESS_KEY" -Dit.test=DestroyTestClusters
{code}


> Add option to leave cluster running when integration tests fail
> ---------------------------------------------------------------
>
>                 Key: WHIRR-152
>                 URL: https://issues.apache.org/jira/browse/WHIRR-152
>             Project: Whirr
>          Issue Type: Improvement
>          Components: core
>            Reporter: Tom White
>         Attachments: WHIRR-152.patch
>
>
> This would be useful for debugging why tests failed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.