You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Ruben Janssen (JIRA)" <ji...@apache.org> on 2017/05/25 22:04:04 UTC
[jira] [Comment Edited] (SPARK-20891) Reduce duplicate code in
typedaggregators.scala
[ https://issues.apache.org/jira/browse/SPARK-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025459#comment-16025459 ]
Ruben Janssen edited comment on SPARK-20891 at 5/25/17 10:03 PM:
-----------------------------------------------------------------
I thought it would be cleaner to have separate JIRAs because this would be needed despite the addition of new features, rather than doing it in 20890.
For example, if someone wanted to add a new function while SPARK-20890 was still pending, we would need another subsequent JIRA to fix the duplicate code, as the new function would not be aligned with the code duplication measures taken in 20890.
I don't mind closing this JIRA however and resolving the code duplication issue in 20891 however, if you prefer.
was (Author: rubenjanssen):
I thought it would be cleaner to have separate JIRAs because this would be needed despite the addition of new features.
For example, if someone wanted to add a new function while SPARK-20890 was still pending, we would need another subsequent JIRA to fix the duplicate code, as the new function would not be aligned with the code duplication measures taken in 20890.
I don't mind closing this JIRA however and resolving the code duplication issue in 20891 however, if you prefer.
> Reduce duplicate code in typedaggregators.scala
> -----------------------------------------------
>
> Key: SPARK-20891
> URL: https://issues.apache.org/jira/browse/SPARK-20891
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 2.3.0
> Reporter: Ruben Janssen
>
> With SPARK-20411, a significant amount of functions will be added to typedaggregators.scala, resulting in a large amount of duplicate code
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org