[GitHub] [beam] chamikaramj commented on a change in pull request #17244: [BEAM-14014] Support impersonation credentials in dataflow runner

[GitBox <gi...@apache.org>]

chamikaramj commented on a change in pull request #17244:
URL: https://github.com/apache/beam/pull/17244#discussion_r840775779



##########
File path: sdks/python/apache_beam/internal/gcp/auth.py
##########
@@ -125,30 +139,22 @@ def get_service_credentials(cls):
           "socket default timeout is %s seconds.", socket.getdefaulttimeout())
 
       cls._credentials = cls._get_service_credentials()
+      cls._add_impersonation_credentials()
       cls._credentials_init = True
 
     return cls._credentials
 
   @staticmethod
-  def _get_service_credentials():
+  def _get_service_credentials(cls):
     if not _GOOGLE_AUTH_AVAILABLE:
       _LOGGER.warning(
           'Unable to find default credentials because the google-auth library '
           'is not available. Install the gcp extra (apache_beam[gcp]) to use '
           'Google default credentials. Connecting anonymously.')
       return None
 
-    client_scopes = [
-        'https://www.googleapis.com/auth/bigquery',

Review comment:
       +1. That will make things much more consistent for x-lang (and users of different SDKs in general).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org