You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Chris Hostetter <ho...@fucit.org> on 2016/05/04 04:19:22 UTC

Re: post-branch_6x Jira version renaming(s) got overlooked?

I've filed LUCENE-7271 to track the work that needs done, and included 
full details on exactly what i plan to do.

I'll try to get started sometime tomorrow unless anyone chimes in on that 
jira with concerns/suggested improvements to the plan...

https://issues.apache.org/jira/browse/LUCENE-7271



: Date: Fri, 29 Apr 2016 15:41:06 -0700 (MST)
: From: Chris Hostetter <ho...@fucit.org>
: To: Lucene Dev <de...@lucene.apache.org>
: Subject: Re: post-branch_6x Jira version renaming(s) got overlooked?
: 
: 
: : OK. I'm not sure you're missing anything. But, I think we'll all know
: : for sure pretty quickly once we're doing it.
: 
: That sounds like a ringing vote of confidence!
: 
: 
: : Do you want help with this? Seems like you have it under control, but
: : if you want to split it somehow, I can help a bit this afternoon.
: 
: Not just yet thanks ... i want to mull it a bit more, and maybe start on 
: it monday.
: 
: One thing i'll definitely do before i start changing anything is use the 
: "Bulk Edit" feature to add *comments* with 2 new unique magic strings to 
: all of the issues that match the queries against the current "master" or 
: "6.0"
: 
: Once thats done then we should be able to merge the versions with 
: confidence, because we should always be able to do searches to find those 
: 2 distinct sets again if something gets fucked up and needs manually fixed 
: -- and the various audits we need/want to do can be done after the fact 
: using searches on those magic strings.
: 
: when it's time for auditing those ~100 6.1 jiras it might be worth 
: splitting up the work, but it should go pretty quick.
: 
: 
: : 
: : On Fri, Apr 29, 2016 at 2:47 PM, Chris Hostetter
: : <ho...@fucit.org> wrote:
: : >
: : > : Yeah, good point, I forgot about the permutations with backported issues.
: : > :
: : > : But it's not just master + 6.1,  it's also master + 6.0. That's why
: : > : the query I sent out looked for issues that had "master", but not
: : > : either of those versions. If it's marked for 6.0 and also master, then
: : > : it's meant for 7.0 (eventually).
: : >
: : > Not neccessarily -- we have no way of nowing when "master" was put in
: : > fixVersion, so "6.0, master" might mean "commited to master=7.0 and
: : > branch_6x=6.0" or it might mean "commited to master which was then later
: : > forked to branch_6x but then someone also added 6.0 explicitly when
: : > resolving"
: : >
: : > in general, if we're going to merge master->6.0 we don't have to worry
: : > about any issues that *currently* list both -- that wll be resolved when
: : > they merge.
: : >
: : > I'm pretty sure we only have to worry about:
: : >
: : > a) issues that list both "master
: : > + 6.1" and wether that really means "commited to branch_6_0=6.0 and
: : > branch_6x=6.1" or "commited to master=7.0 and branch_6x=6.0" ... which is
: : > why i suggested a manual audit based on jira query.
: : >
: : > b) issues that *should* only list "master" once we are all done ... which
: : > should be a really straight forward audit of the 7.0 CHANGES.txt.
: : >
: : > ...or am i still missing something?
: : >
: : > : generally assumed. We could remove master from all issues that already
: : > : have another fixVersion (except the forward ones, 6.0 and 6.1), and
: : > : then just deal with that list. It's much more manageable:
: : > :
: : > : https://issues.apache.org/jira/browse/SOLR-9046?jql=project%20%3D%20SOLR%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%20master%20AND%20fixVersion%20not%20in%20releasedVersions()
: : >
: : > how would we remove master from master from those issues? the "Bulk Edit
: : > replaces whole field" problem would force us to remove all fixVersions in
: : > that case wouldn't it?
: : >
: : >
: : >
: : >
: : >
: : > : > : > for both the LUCENE and SOLR project...
: : > : > : >
: : > : > : > 1) Audit the list of Jira's with 'fixVersion=mater AND fixVersion=6.1' and
: : > : > : > manually remove master from all of them (only ~100 total)
: : > : > : > 2) merge "master" into "6.0"
: : > : > : > 3) re add a "master" version to Jira
: : > : > : > 3) Audit CHANGES.txt and set fixVersion=master on the handful of issues in
: : > : > : > the 7.0 section
: : >
: : > -Hoss
: : > http://www.lucidworks.com/
: : >
: : > ---------------------------------------------------------------------
: : > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
: : > For additional commands, e-mail: dev-help@lucene.apache.org
: : >
: : 
: : ---------------------------------------------------------------------
: : To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
: : For additional commands, e-mail: dev-help@lucene.apache.org
: : 
: : 
: 
: -Hoss
: http://www.lucidworks.com/
: 

-Hoss
http://www.lucidworks.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org