[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare

["Daniel Kuppitz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637280#comment-16637280 ] 

Daniel Kuppitz commented on TINKERPOP-2056:
-------------------------------------------

Kinda related: {{Contains}} doesn't convert differing number types at all.

{noformat}
gremlin> g.V().has("age", eq(32L))
==>v[4]
gremlin> g.V().has("age", within(32L, 35L))
gremlin> 
{noformat}

The problem though: This behavior is enforced by the test suite and a change would be breaking. Hence I'm going to include the {{Compare}} changes in the {{tp32}} PR and I will create another PR for {{master/}} that also includes the {{Contains}} changes.

> Use NumberHelper in Compare
> ---------------------------
>
>                 Key: TINKERPOP-2056
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2056
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.9
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>            Priority: Major
>
> The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest thing we can do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)