You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/10 12:34:24 UTC
[GitHub] [flink] zentol commented on a change in pull request #17424: [FLINK-24455][tests]FallbackAkkaRpcSystemLoader should check for mave…
zentol commented on a change in pull request #17424:
URL: https://github.com/apache/flink/pull/17424#discussion_r746541431
##########
File path: flink-rpc/flink-rpc-akka-loader/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcSystemLoader.java
##########
@@ -42,6 +43,15 @@
*/
public class AkkaRpcSystemLoader implements RpcSystemLoader {
+ /**
+ * The name of the akka dependency jar, which should be correspond to the artifact output copied
+ * to flink-runtime module.
Review comment:
```suggestion
* The name of the akka dependency jar, which must match the jar that is bundled by the flink-rpc-akka-loader module.
```
We no longer copy a jar to flink-runtime.
##########
File path: flink-rpc/flink-rpc-akka-loader/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcSystemLoader.java
##########
@@ -42,6 +43,15 @@
*/
public class AkkaRpcSystemLoader implements RpcSystemLoader {
+ /**
+ * The name of the akka dependency jar, which should be correspond to the artifact output copied
+ * to flink-runtime module.
+ */
+ private static final String FLINK_RPC_AKKA_FAT_JAR = "flink-rpc-akka.jar";
+
+ protected static final String HINT_USAGE =
Review comment:
```suggestion
static final String HINT_USAGE =
```
Seems more appropriate.
##########
File path: flink-rpc/flink-rpc-akka-loader/src/test/java/org/apache/flink/runtime/rpc/akka/FallbackAkkaRpcSystemLoader.java
##########
@@ -67,7 +71,13 @@ public RpcSystem loadRpcSystem(Configuration config) {
akkaRpcModuleDirectory.resolve(Paths.get("target", "dependencies"));
if (!Files.exists(akkaRpcModuleDependenciesDirectory)) {
- downloadDependencies(akkaRpcModuleDirectory, akkaRpcModuleDependenciesDirectory);
+ int exitCode =
+ downloadDependencies(
+ akkaRpcModuleDirectory, akkaRpcModuleDependenciesDirectory);
+ if (exitCode != 0) {
+ throw new RuntimeException(
+ "Can not download dependencies, please see the output log for reason.");
Review comment:
```suggestion
"Could not download dependencies of flink-rpc-akka, please see the log output for details.");
```
##########
File path: flink-rpc/flink-rpc-akka-loader/src/test/java/org/apache/flink/runtime/rpc/akka/FallbackAkkaRpcSystemLoader.java
##########
@@ -67,7 +71,13 @@ public RpcSystem loadRpcSystem(Configuration config) {
akkaRpcModuleDirectory.resolve(Paths.get("target", "dependencies"));
if (!Files.exists(akkaRpcModuleDependenciesDirectory)) {
- downloadDependencies(akkaRpcModuleDirectory, akkaRpcModuleDependenciesDirectory);
+ int exitCode =
+ downloadDependencies(
+ akkaRpcModuleDirectory, akkaRpcModuleDependenciesDirectory);
+ if (exitCode != 0) {
+ throw new RuntimeException(
Review comment:
```suggestion
throw new RpcLoaderException(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org