You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by je...@apache.org on 2019/04/12 17:07:42 UTC

[geode] branch develop updated: GEODE-6643: Fix intermittent failure of GfshCommandIntegrationTest on Windows (#3452)

This is an automated email from the ASF dual-hosted git repository.

jensdeppe pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new fb7eadf  GEODE-6643: Fix intermittent failure of GfshCommandIntegrationTest on Windows (#3452)
fb7eadf is described below

commit fb7eadf7f738ae8c3a0cc21afca037c75c610324
Author: Jens Deppe <jd...@pivotal.io>
AuthorDate: Fri Apr 12 10:07:24 2019 -0700

    GEODE-6643: Fix intermittent failure of GfshCommandIntegrationTest on Windows (#3452)
    
    - Honestly this is just a workaround as it's more likely that some
      lingering, existing process is causing this to fail.
    
    Authored-by: Jens Deppe <jd...@pivotal.io>
---
 .../management/internal/cli/commands/GfshCommandIntegrationTest.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/geode-core/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java b/geode-core/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java
index a7248cf..020c097 100644
--- a/geode-core/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java
+++ b/geode-core/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java
@@ -62,7 +62,7 @@ public class GfshCommandIntegrationTest {
     gfsh.executeAndAssertThat(
         "start locator --properties-file=unknown --J=-Dgemfire.security-password=bob")
         .statusIsError();
-    gfsh.executeAndAssertThat("connect --password=secret").statusIsError();
+    gfsh.executeAndAssertThat("connect --jmx-manager=localhost[999] --password=secret").statusIsError();
 
     List<LogEvent> logEvents = listAppender.getEvents();
     assertThat(logEvents.size()).as("There should be exactly 2 log events").isEqualTo(2);
@@ -71,7 +71,7 @@ public class GfshCommandIntegrationTest {
     assertThat(logEvents.get(0).getMessage().getFormattedMessage()).isEqualTo(
         "Executing command: start locator --properties-file=unknown --J=-Dgemfire.security-password=********");
     assertThat(logEvents.get(1).getMessage().getFormattedMessage())
-        .isEqualTo("Executing command: connect --password=********");
+        .isEqualTo("Executing command: connect --jmx-manager=localhost[999] --password=********");
 
     logger.removeAppender(listAppender);
   }