You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2007/02/20 08:37:05 UTC
[jira] Created: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Code cleanups for the org.apache.derby.impl.store.access.* packages
-------------------------------------------------------------------
Key: DERBY-2359
URL: https://issues.apache.org/jira/browse/DERBY-2359
Project: Derby
Issue Type: Improvement
Components: Store
Affects Versions: 10.3.0.0
Reporter: Kristian Waagan
Assigned To: Kristian Waagan
Priority: Minor
When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
Changes the will/may be made:
* remove unused imports
* remove unused methods
* fix JavaDoc errors
* tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480006 ]
Kristian Waagan commented on DERBY-2359:
----------------------------------------
Committed 'derby-2359-2a_method-renames.diff' to trunk with revision 517129.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Fix Version/s: 10.4.0.0
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat, derby-2359-4a-OpenConglomerateScratchSpace.diff, derby-2359-5a-Conglomerate_API_change.diff
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Committed 'derby-2359-1b-unused_imports.diff ' with revision 510538.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-2359.
----------------------------------
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat, derby-2359-4a-OpenConglomerateScratchSpace.diff, derby-2359-5a-Conglomerate_API_change.diff
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502676 ]
Myrna van Lunteren commented on DERBY-2359:
-------------------------------------------
It's been a while since this saw action. Is it done?
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Attachment: (was: derby-2359-1a-unused_imports.diff)
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Attachment: derby-2359-1a-unused_imports.stat
derby-2359-1a-unused_imports.diff
Removed unused imports from the "access layer" packages.
This is how diffstat summarizes it:
147 files changed, 82 insertions(+), 905 deletions(-)
Changes:
- removal of unused imports
- reordering of imports where I had already removed many
- moved/reformatted some class JavaDocs
- deleted some whitespace (blank lines due to removed imports)
I rebuilt and ran suites.All/derbyall without failures (except for the metadata fauilure).
I have one question:
In some of the classes, there are imports for other classes in the same package. Is it okay to remove these, or where they added to document something?
The patch version 1a is not for commit. I will upload 1b in a day or two and commit it if I get no pushback. The only change will be removal of more of the "same package" imports.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Fix Version/s: (was: 10.3.0.0)
This issue is not done. I have at least two (small) patches to submit/commit, but I do not know if I can do that for 10.3.
Delaying these till after 10.3 is not a problem at all.
I'm unchecking the fix version.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488304 ]
Kristian Waagan commented on DERBY-2359:
----------------------------------------
Committed 'derby-2359-3a-visibility_changes.diff' to trunk with revision 527842.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2359:
--------------------------------------
Attachment: btreeforwardscan_cleanup.diff
BTreeForwardScan contains a workaround for a problem in mssdk302, which I don't think can be used to build/run Derby anymore. btreeforwardscan_cleanup.diff removes the workaround. All tests passed.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Attachment: derby-2359-2a_method-renames.stat
derby-2359-2a_method-renames.diff
'derby-2359-2a_method-renames.diff' renames methods where the first letter is uppercase.
The source compiles, and for good measure I ran suites.All as well. No errors.
I will commit this shortly.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Attachment: derby-2359-1a-unused_imports.stat
derby-2359-1a-unused_imports.diff
Misread the license option... Sorry for the inconvenience.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1a-unused_imports.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Fix Version/s: 10.3.0.0
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2359:
--------------------------------------
Derby Info: (was: [Patch Available])
Committed revision 522442.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Attachment: (was: derby-2359-1a-unused_imports.stat)
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Derby Info: [Patch Available]
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat, derby-2359-4a-OpenConglomerateScratchSpace.diff, derby-2359-5a-Conglomerate_API_change.diff
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Attachment: derby-2359-3a-visibility_changes.stat
derby-2359-3a-visibility_changes.diff
'derby-2359-3a-visibility_changes.diff' reduces the visibility of a number of fields. The code compiles and suites.All ran without failures. I'm running derbyall now.
Expecting to commit shortly.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2359:
--------------------------------------
Derby Info: [Patch Available]
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552812 ]
Kristian Waagan commented on DERBY-2359:
----------------------------------------
I want to remove the unused parameter 'conglomId' of the method 'getDynamicCompiledConglomInfo' in the interface 'iapi.store.access.conglomerate.Conglomerate'.
Does anyone see any problems about doing that?
Note that there is another method of the same name and with the same parameter in the interface 'TransactionController'. In this case the parameter is used.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan resolved DERBY-2359.
------------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Committed 'derby-2359-4a-OpenConglomerateScratchSpace.diff' to trunk with revision 609543.
Committed 'derby-2359-5a-Conglomerate_API_change.diff' to trunk with revision 609558.
Marking issue as fixed, since I do not plan to make more changes.
Will close the issue in a few days.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat, derby-2359-4a-OpenConglomerateScratchSpace.diff, derby-2359-5a-Conglomerate_API_change.diff
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Attachment: derby-2359-5a-Conglomerate_API_change.diff
derby-2359-4a-OpenConglomerateScratchSpace.diff
I committed two changes to trunk with revision 608466, which removed a self-assignment and an unused locale variable.
'derby-2359-4a-OpenConglomerateScratchSpace.diff' contains a few cleanups (unused method and variable, some JavaDoc).
'derby-2359-5a-Conglomerate_API_change.diff' removes the unused argument 'conglomId' from the Conglomerate interface.
I've run tests for both patches, and I saw no related failures.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: btreeforwardscan_cleanup.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat, derby-2359-2a_method-renames.diff, derby-2359-2a_method-renames.stat, derby-2359-3a-visibility_changes.diff, derby-2359-3a-visibility_changes.stat, derby-2359-4a-OpenConglomerateScratchSpace.diff, derby-2359-5a-Conglomerate_API_change.diff
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2359) Code cleanups for the
org.apache.derby.impl.store.access.* packages
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2359:
-----------------------------------
Attachment: derby-2359-1b-unused_imports.stat
derby-2359-1b-unused_imports.diff
'derby-2359-1b-unused_imports.diff' removes unused imports, also import for classes in the same package as the importing class. Updated diffstat:
63 files changed, 81 insertions(+), 490 deletions(-)
I was a bit too eager, and removed unused imports for store.raw as well as store.access. I have split the patch into two, and will create a new Jira for the store.raw packages.
Also note that I had to change some JavaDoc @see tags due to the removed imports. Where the package names got too long, I imported the class instead and added a comment, like this:
// For JavaDoc references (i.e. @see)
import org.apache.derby.iapi.store.access.conglomerate.MethodFactory;
I plan to commit this patch tomorrow.
> Code cleanups for the org.apache.derby.impl.store.access.* packages
> -------------------------------------------------------------------
>
> Key: DERBY-2359
> URL: https://issues.apache.org/jira/browse/DERBY-2359
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.diff, derby-2359-1a-unused_imports.stat, derby-2359-1a-unused_imports.stat, derby-2359-1b-unused_imports.diff, derby-2359-1b-unused_imports.stat
>
>
> When trying to learn more about the access layer, it was discovered that some code improvements could easily be made to increase the readability of the code.
> Patches attached to this issue will be cleanup patches only, and no functionality should be changed.
> Changes the will/may be made:
> * remove unused imports
> * remove unused methods
> * fix JavaDoc errors
> * tighter encapsulation and removal of unused variables where appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.