You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Barna Zsombor Klara <zs...@cloudera.com> on 2016/09/20 10:37:44 UTC
Review Request 52079: HIVE-14753: Track the number of
open/closed/abandoned sessions in HS2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52079/
-----------------------------------------------------------
Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.
Repository: hive-git
Description
-------
HIVE-14753: Track the number of open/closed/abandoned sessions in HS2
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java 9be9b50aa02ff88816eb92079eaff9afa3e1be90
common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 4297233ed12a7d9a2fa03ac3204e8335c0aed821
common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java 9dc96f9c6412720a891b5c55e2074049c893d780
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java 4c433678bd62ea74b80babce9856681192deb25f
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java PRE-CREATION
common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java 46676589e6656d0f13f1931bfe67a63dd1920042
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 15bab0660fcb9a997d66f6ff0a5dbc0e39c37ae7
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 5511c54ff431211f7f72deaa017c915b839dfb2a
Diff: https://reviews.apache.org/r/52079/diff/
Testing
-------
Ran the unit tests in the common and the ql subprojects.
Manually verified the metrics using the HS2 webui metric dump.
Thanks,
Barna Zsombor Klara
Re: Review Request 52079: HIVE-14753: Track the number of
open/closed/abandoned sessions in HS2
Posted by Gabor Szadovszky <ga...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52079/#review149643
-----------------------------------------------------------
Ship it!
Thanks for the patch. LGTM.
- Gabor Szadovszky
On Sept. 20, 2016, 10:37 a.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52079/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2016, 10:37 a.m.)
>
>
> Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14753: Track the number of open/closed/abandoned sessions in HS2
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java 9be9b50aa02ff88816eb92079eaff9afa3e1be90
> common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 4297233ed12a7d9a2fa03ac3204e8335c0aed821
> common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java 9dc96f9c6412720a891b5c55e2074049c893d780
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java 4c433678bd62ea74b80babce9856681192deb25f
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java PRE-CREATION
> common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java 46676589e6656d0f13f1931bfe67a63dd1920042
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java 15bab0660fcb9a997d66f6ff0a5dbc0e39c37ae7
> service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 5511c54ff431211f7f72deaa017c915b839dfb2a
>
> Diff: https://reviews.apache.org/r/52079/diff/
>
>
> Testing
> -------
>
> Ran the unit tests in the common and the ql subprojects.
> Manually verified the metrics using the HS2 webui metric dump.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 52079: HIVE-14753: Track the number of
open/closed/abandoned sessions in HS2
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52079/#review153432
-----------------------------------------------------------
Ship it!
Sorry for the delay, lgtm
- Szehon Ho
On Oct. 17, 2016, 10:57 a.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52079/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 10:57 a.m.)
>
>
> Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14753: Track the number of open/closed/abandoned sessions in HS2
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java ba2267b29eaeb497e9582ca3ff3de4ad63bf8482
> common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 9b263d91321f141adf73e5421f3d659f80081471
> common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java c9d4087c5aeaf7f1ca0e9b5860b898b5766cd911
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java 9525b452eada8ab6a2dd56895f9c9d4eb50db894
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java PRE-CREATION
> common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java 46676589e6656d0f13f1931bfe67a63dd1920042
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java 76e759f23fdbc60629397121fd2522e6e9251a85
> service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 82126c053f13309013035c6f900bd5d37170bdae
>
> Diff: https://reviews.apache.org/r/52079/diff/
>
>
> Testing
> -------
>
> Ran the unit tests in the common and the ql subprojects.
> Manually verified the metrics using the HS2 webui metric dump.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 52079: HIVE-14753: Track the number of
open/closed/abandoned sessions in HS2
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52079/
-----------------------------------------------------------
(Updated Oct. 17, 2016, 10:57 a.m.)
Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.
Changes
-------
Rebased the patch as TestSessionManagerMetrics has been modified. Made changes to prevent potential flakyness of the tests.
Repository: hive-git
Description
-------
HIVE-14753: Track the number of open/closed/abandoned sessions in HS2
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java ba2267b29eaeb497e9582ca3ff3de4ad63bf8482
common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 9b263d91321f141adf73e5421f3d659f80081471
common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java c9d4087c5aeaf7f1ca0e9b5860b898b5766cd911
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java 9525b452eada8ab6a2dd56895f9c9d4eb50db894
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java PRE-CREATION
common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java 46676589e6656d0f13f1931bfe67a63dd1920042
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 76e759f23fdbc60629397121fd2522e6e9251a85
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 82126c053f13309013035c6f900bd5d37170bdae
Diff: https://reviews.apache.org/r/52079/diff/
Testing
-------
Ran the unit tests in the common and the ql subprojects.
Manually verified the metrics using the HS2 webui metric dump.
Thanks,
Barna Zsombor Klara
Re: Review Request 52079: HIVE-14753: Track the number of
open/closed/abandoned sessions in HS2
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52079/
-----------------------------------------------------------
(Updated Oct. 14, 2016, 10:35 a.m.)
Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.
Changes
-------
Introduced the methods registerOpenSesssionMetrics and registerActiveSesssionMetrics to make the init method more readable and concise.
Repository: hive-git
Description
-------
HIVE-14753: Track the number of open/closed/abandoned sessions in HS2
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java ba2267b29eaeb497e9582ca3ff3de4ad63bf8482
common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 9b263d91321f141adf73e5421f3d659f80081471
common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java c9d4087c5aeaf7f1ca0e9b5860b898b5766cd911
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java 9525b452eada8ab6a2dd56895f9c9d4eb50db894
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java PRE-CREATION
common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java 46676589e6656d0f13f1931bfe67a63dd1920042
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 76e759f23fdbc60629397121fd2522e6e9251a85
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 5511c54ff431211f7f72deaa017c915b839dfb2a
Diff: https://reviews.apache.org/r/52079/diff/
Testing
-------
Ran the unit tests in the common and the ql subprojects.
Manually verified the metrics using the HS2 webui metric dump.
Thanks,
Barna Zsombor Klara
Re: Review Request 52079: HIVE-14753: Track the number of
open/closed/abandoned sessions in HS2
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52079/#review152576
-----------------------------------------------------------
Fix it, then Ship it!
Looks good, just minor comments. Assume you've tested it
service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 100)
<https://reviews.apache.org/r/52079/#comment221634>
Can we move this to a helper method?
service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 145)
<https://reviews.apache.org/r/52079/#comment221635>
Helper method for this?
- Szehon Ho
On Oct. 3, 2016, 1:31 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52079/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2016, 1:31 p.m.)
>
>
> Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14753: Track the number of open/closed/abandoned sessions in HS2
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java ba2267b29eaeb497e9582ca3ff3de4ad63bf8482
> common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 9b263d91321f141adf73e5421f3d659f80081471
> common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java c9d4087c5aeaf7f1ca0e9b5860b898b5766cd911
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java 9525b452eada8ab6a2dd56895f9c9d4eb50db894
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java PRE-CREATION
> common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java 46676589e6656d0f13f1931bfe67a63dd1920042
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java 76e759f23fdbc60629397121fd2522e6e9251a85
> service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 5511c54ff431211f7f72deaa017c915b839dfb2a
>
> Diff: https://reviews.apache.org/r/52079/diff/
>
>
> Testing
> -------
>
> Ran the unit tests in the common and the ql subprojects.
> Manually verified the metrics using the HS2 webui metric dump.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 52079: HIVE-14753: Track the number of
open/closed/abandoned sessions in HS2
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52079/
-----------------------------------------------------------
(Updated Oct. 3, 2016, 1:31 p.m.)
Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.
Changes
-------
Rebased to master HEAD
Repository: hive-git
Description
-------
HIVE-14753: Track the number of open/closed/abandoned sessions in HS2
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java ba2267b29eaeb497e9582ca3ff3de4ad63bf8482
common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 9b263d91321f141adf73e5421f3d659f80081471
common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java c9d4087c5aeaf7f1ca0e9b5860b898b5766cd911
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java 9525b452eada8ab6a2dd56895f9c9d4eb50db894
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java PRE-CREATION
common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java 46676589e6656d0f13f1931bfe67a63dd1920042
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 76e759f23fdbc60629397121fd2522e6e9251a85
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 5511c54ff431211f7f72deaa017c915b839dfb2a
Diff: https://reviews.apache.org/r/52079/diff/
Testing
-------
Ran the unit tests in the common and the ql subprojects.
Manually verified the metrics using the HS2 webui metric dump.
Thanks,
Barna Zsombor Klara
Re: Review Request 52079: HIVE-14753: Track the number of
open/closed/abandoned sessions in HS2
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52079/#review149648
-----------------------------------------------------------
LGTM,
Thanks for the patch
- Peter Vary
On Sept. 20, 2016, 10:37 a.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52079/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2016, 10:37 a.m.)
>
>
> Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14753: Track the number of open/closed/abandoned sessions in HS2
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java 9be9b50aa02ff88816eb92079eaff9afa3e1be90
> common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 4297233ed12a7d9a2fa03ac3204e8335c0aed821
> common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java 9dc96f9c6412720a891b5c55e2074049c893d780
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java 4c433678bd62ea74b80babce9856681192deb25f
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java PRE-CREATION
> common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java 46676589e6656d0f13f1931bfe67a63dd1920042
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java 15bab0660fcb9a997d66f6ff0a5dbc0e39c37ae7
> service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 5511c54ff431211f7f72deaa017c915b839dfb2a
>
> Diff: https://reviews.apache.org/r/52079/diff/
>
>
> Testing
> -------
>
> Ran the unit tests in the common and the ql subprojects.
> Manually verified the metrics using the HS2 webui metric dump.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>