[GitHub] [spark] clownxc commented on pull request #40707: [SPARK-43033][SQL] Avoid task retries due to AssertNotNull checks

["clownxc (via GitHub)" <gi...@apache.org>]

clownxc commented on PR #40707:
URL: https://github.com/apache/spark/pull/40707#issuecomment-1511354240

   According to the two ideas provided by @cloud-fan  on how to differentiate user-facing errors and user-triggered errors ([have a special prefix] or [create a base trait for transient errors]), in the implementation process, I think having a special prefix may be a more good idea.
   I defined a new `SparkThrowable#isTransientError` method with reference to `SparkThrowable#isInternalError`, and decided whether to skip the retry logic based on the return value of the `SparkThrowable#isTransientError`.
   can you re-review the code when you are free, and make some comments. @cloud-fan @aokolnychyi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org