You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2016/04/20 18:54:51 UTC
Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/
-----------------------------------------------------------
(Updated April 20, 2016, 4:54 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Summary (updated)
-----------------
Windows: [4/4] Updated `sendfile` test.
Repository: mesos
Description (updated)
-------
Windows: [4/4] Updated `sendfile` test.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a
Diff: https://reviews.apache.org/r/46293/diff/
Testing
-------
OSX: make check
Thanks,
Daniel Pravat
Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129784
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (lines 81 - 88)
<https://reviews.apache.org/r/46293/#comment193339>
Sorry, from the `result.error().code` comment: by "Here and below" I also meant that we should use `result.error().message` rather than `os::strerror(_errno)`. Could you also update that please?
- Michael Park
On April 20, 2016, 4:54 p.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 4:54 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: [4/4] Updated `sendfile` test.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a
>
> Diff: https://reviews.apache.org/r/46293/diff/
>
>
> Testing
> -------
>
> OSX: make check
>
>
> Thanks,
>
> Daniel Pravat
>
>
Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review130049
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On April 20, 2016, 9:48 p.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 9:48 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: [4/4] Updated `sendfile` test.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a
>
> Diff: https://reviews.apache.org/r/46293/diff/
>
>
> Testing
> -------
>
> OSX: make check
>
>
> Thanks,
>
> Daniel Pravat
>
>
Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/
-----------------------------------------------------------
(Updated April 20, 2016, 9:48 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Repository: mesos
Description
-------
Windows: [4/4] Updated `sendfile` test.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a
Diff: https://reviews.apache.org/r/46293/diff/
Testing
-------
OSX: make check
Thanks,
Daniel Pravat