You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yew1eb <gi...@git.apache.org> on 2018/02/03 06:27:08 UTC
[GitHub] flink pull request #5406: [hotfix][docs] Fix typos
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5406
[hotfix][docs] Fix typos
Hotfix some typos in comments.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink fix_typos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5406.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5406
----
commit 05b708e7a417b1337ec91c19b0f66a951635dd1d
Author: zhouhai02 <zh...@...>
Date: 2018-02-03T06:08:29Z
[hotfix][docs] Fix typos
----
---
[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5406#discussion_r165807220
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java ---
@@ -90,11 +90,11 @@
CompletableFuture<Acknowledge> releaseTaskManager(final ResourceID resourceId);
/**
- * Offers a slot to the {@link SlotPool}. The slot offer can be accepted or
+ * Offers a slot to the {@link SlotPool}. The slot offers can be accepted or
* rejected.
*
- * @param taskManagerLocation from which the slot offer originates
- * @param taskManagerGateway to talk to the slot offerer
+ * @param taskManagerLocation from which the slot offers originate
--- End diff --
given that this method offers a single slot using singular makes more sense
---
[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5406#discussion_r165916481
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java ---
@@ -108,7 +108,7 @@
* individually accepted or rejected by returning the collection of accepted
* slot offers.
*
- * @param taskManagerLocation from which the slot offers originate
+ * @param taskManagerLocation from which the slot offer originates
--- End diff --
this method on the other hand offers multiple slots, so plural makes more sense.
---
[GitHub] flink issue #5406: [hotfix] Fix typos in comments.
Posted by yew1eb <gi...@git.apache.org>.
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5406
:satisfied: , I addressed your comments.
---
[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5406#discussion_r165807233
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java ---
@@ -90,11 +90,11 @@
CompletableFuture<Acknowledge> releaseTaskManager(final ResourceID resourceId);
/**
- * Offers a slot to the {@link SlotPool}. The slot offer can be accepted or
+ * Offers a slot to the {@link SlotPool}. The slot offers can be accepted or
* rejected.
*
- * @param taskManagerLocation from which the slot offer originates
- * @param taskManagerGateway to talk to the slot offerer
+ * @param taskManagerLocation from which the slot offers originate
+ * @param taskManagerGateway to talk to the slot offers
--- End diff --
the previous version was correct
---
[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5406
---
[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5406#discussion_r165807228
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java ---
@@ -109,7 +109,7 @@
* slot offers.
*
* @param taskManagerLocation from which the slot offers originate
- * @param taskManagerGateway to talk to the slot offerer
+ * @param taskManagerGateway to talk to the slot offers
--- End diff --
the previous version was correct
---
[GitHub] flink issue #5406: [hotfix] Fix typos in comments.
Posted by yew1eb <gi...@git.apache.org>.
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5406
@zentol thanks for your attention to this PR, I had updated this PR according to your comments.
---