You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "neilcsmith-net (via GitHub)" <gi...@apache.org> on 2023/03/20 14:01:36 UTC
[GitHub] [netbeans-nbpackage] neilcsmith-net opened a new pull request, #21: Refactor AbstractPackagerTask to support image filtering
neilcsmith-net opened a new pull request, #21:
URL: https://github.com/apache/netbeans-nbpackage/pull/21
In order to support filtering (merging / deleting files) of the image after customization, need to refactor the abstract task into separate template steps / hooks.
Work in progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] neilcsmith-net commented on pull request #21: Refactor AbstractPackagerTask to support image filtering
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #21:
URL: https://github.com/apache/netbeans-nbpackage/pull/21#issuecomment-1480336155
> There is a list of hard-coded files/directories in the current [`rpm.spec.template`](https://github.com/apache/netbeans-nbpackage/blob/master/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template). With your change, that list is no longer needed; it is generated dynamically.
Yes, that should be changed already in https://github.com/apache/netbeans-nbpackage/pull/21/files#diff-6a712fcb595d56bad2e1385e8c83c209fb3d20ffcefb05f87f9ca2f264b6b0cd
> Then that remove pattern you mention should be used for the next NetBeans release rpm/deb package.
I wasn't planning to propose that change. Could possibly be discussed but there are benefits to keeping the zip contents intact too. Obviously you could build packages with this that do filter out whatever you don't want to include.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] javierllorente commented on pull request #21: Refactor AbstractPackagerTask to support image filtering
Posted by "javierllorente (via GitHub)" <gi...@apache.org>.
javierllorente commented on PR #21:
URL: https://github.com/apache/netbeans-nbpackage/pull/21#issuecomment-1480299465
> > Content below `%files` in `rpm.spec.template` needs to be removed.
>
> What content? `${RPM_FILE}` is literally the newly calculated file list. That should be there as far as I know. It can't be empty?
There is a list of hard-coded files/directories in the current [`rpm.spec.template`](https://github.com/apache/netbeans-nbpackage/blob/master/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template). With your change, that list is no longer needed; it is generated dynamically.
> > I am not seeing any call to broom action. Besides `*.exe`, I would also remove `*.bat` and `*.dll` and clean the following directories: ` /usr/lib/apache-netbeans/ide/bin/nativeexecution/` ` /usr/lib/apache-netbeans/profiler/remote-pack-defs/`
>
> There will be no default removal. You can set it in configuration files using `package.remove=<PATTERN>` or on the command line with `-Premove=<PATTERN>`. For that you would use `{*.exe,*.bat,*.dll,**/nativeexecution/MacOSX-*/*, .... }`. See also the glob patterns for macOS signing, which cover some of the same files - https://github.com/apache/netbeans-nbpackage/blob/master/src/main/java/org/apache/netbeans/nbpackage/macos/MacOS.java#L31
Understood. Then that remove pattern you mention should be used for the next NetBeans release rpm/deb package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] neilcsmith-net commented on pull request #21: Refactor AbstractPackagerTask to support image filtering
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #21:
URL: https://github.com/apache/netbeans-nbpackage/pull/21#issuecomment-1480222215
> Content below `%files` in `rpm.spec.template` needs to be removed.
What content? `${RPM_FILE}` is literally the newly calculated file list. That should be there as far as I know. It can't be empty?
> I am not seeing any call to broom action. Besides `*.exe`, I would also remove `*.bat` and `*.dll` and clean the following directories: ` /usr/lib/apache-netbeans/ide/bin/nativeexecution/` ` /usr/lib/apache-netbeans/profiler/remote-pack-defs/`
There will be no default removal. You can set it in configuration files using `package.remove=<PATTERN>` or on the command line with `-Premove=<PATTERN>`. For that you would use `{*.exe,*.bat,*.dll,**/nativeexecution/MacOSX-*/*, .... }`. See also the glob patterns for macOS signing, which cover some of the same files - https://github.com/apache/netbeans-nbpackage/blob/master/src/main/java/org/apache/netbeans/nbpackage/macos/MacOS.java#L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] javierllorente commented on pull request #21: Refactor AbstractPackagerTask to support image filtering
Posted by "javierllorente (via GitHub)" <gi...@apache.org>.
javierllorente commented on PR #21:
URL: https://github.com/apache/netbeans-nbpackage/pull/21#issuecomment-1480154548
> cc/ @javierllorente - can't add you as a reviewer, but welcome your thoughts on RPM changes. And on the glob filtering - you asked before about removing `.exe` etc.
Content below `%files` in `rpm.spec.template` needs to be removed.
I am not seeing any call to broom action.
Besides `*.exe`, I would also remove `*.bat` and `*.dll` and clean the following directories:
` /usr/lib/apache-netbeans/ide/bin/nativeexecution/`
` /usr/lib/apache-netbeans/profiler/remote-pack-defs/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] neilcsmith-net commented on pull request #21: Refactor AbstractPackagerTask to support image filtering
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #21:
URL: https://github.com/apache/netbeans-nbpackage/pull/21#issuecomment-1479814634
cc/ @javierllorente - can't add you as a reviewer, but welcome your thoughts on RPM changes. And on the glob filtering - you asked before about removing `.exe` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] neilcsmith-net merged pull request #21: Refactor AbstractPackagerTask to support image filtering
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #21:
URL: https://github.com/apache/netbeans-nbpackage/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists