You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Michael Dick (JIRA)" <ji...@apache.org> on 2008/09/30 19:59:44 UTC

[jira] Created: (OPENJPA-734) Commons DBCP parameters should be configurable.

Commons DBCP parameters should be configurable. 
------------------------------------------------

                 Key: OPENJPA-734
                 URL: https://issues.apache.org/jira/browse/OPENJPA-734
             Project: OpenJPA
          Issue Type: Improvement
            Reporter: Michael Dick
            Assignee: Michael Dick
            Priority: Minor
             Fix For: 1.3.0


Per conversation on the users mailing list [1] it would be nice to make the connection pool used for unit tests configurable. Some environments are not well suited to handle the current list of defaults. 

[1] http://openjpa.markmail.org/message/uctj54wt733wxtp4?q=milosz 
or 
http://n2.nabble.com/Test-suite-slow-on-DB2-td1115993.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OPENJPA-734) Commons DBCP parameters should be configurable.

Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dick closed OPENJPA-734.
--------------------------------

    Resolution: Fixed

Fixed in revision 700603. 

The change adds a dbcp.args property to pom.xml. The property is passed in to the surefire test harness and used when to configure the connection pool.

The property may be set on the command line  or in a profile in .m2/settings.xml. 

Example command line usage : 
$ mvn test -Ddbcp.args=MaxActive =5,MaxIdle=2

Example settings.xml usage: 
<profile>
    <id>unreasonably-large-pool<id>
    <properties> 
         <dbcp.args>MaxActive=1000,MaxIdle=0,MaxWait=500</dbcp.args>
    </properties>
</profile> 

$ mvn test -Punreasonably-large-pool

More practical examples include increasing the MaxIdle to avoid the overhead of creating connections. 

The default settings may be found in pom.xml (openjpa-persistence-jdbc) and are currently MaxActive=100,MaxIdle=0,MaxWait=10000

> Commons DBCP parameters should be configurable. 
> ------------------------------------------------
>
>                 Key: OPENJPA-734
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-734
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>            Priority: Minor
>             Fix For: 1.3.0
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Per conversation on the users mailing list [1] it would be nice to make the connection pool used for unit tests configurable. Some environments are not well suited to handle the current list of defaults. 
> [1] http://openjpa.markmail.org/message/uctj54wt733wxtp4?q=milosz 
> or 
> http://n2.nabble.com/Test-suite-slow-on-DB2-td1115993.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (OPENJPA-734) Commons DBCP parameters should be configurable.

Posted by Craig L Russell <Cr...@Sun.COM>.
Hi Mike,

On Oct 1, 2008, at 12:45 PM, Michael Dick (JIRA) wrote:

>
>    [ https://issues.apache.org/jira/browse/OPENJPA-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636138 
> #action_12636138 ]
>
> Michael Dick commented on OPENJPA-734:
> --------------------------------------
>
> Good point. Currently most of the permissions on the wiki are  
> restricted to OpenJPA developers and admins. If I'm reading the  
> permissions correctly members of the asf-cla group in confluence can  
> also add pages.
>
> I think we'd be better served to go with something similar to  
> Geronimo's approach (seen here : http://cwiki.apache.org/confluence/display/geronimo/Geronimo+cwiki+documentation+architecture 
>  ) with a separate group of contributors who can add to the wiki.
>
> I'll propose this on the developer mailing list, but I suspect it's  
> policy to require a CLA before anyone can add to an Apache website  
> (since the wiki is our website it may require a CLA as well).

Policy or not, it's a good idea to require a CLA to grant write access  
to the wiki, and the PMC is authorized to implement this policy.

We can vote in wiki committers just as we vote in code committers. To  
keep track of these permissions, we can create an artificial group in  
asf-authorization for openjpa-wiki (which I will administer).

Craig
>
>
>> Commons DBCP parameters should be configurable.
>> ------------------------------------------------
>>
>>                Key: OPENJPA-734
>>                URL: https://issues.apache.org/jira/browse/OPENJPA-734
>>            Project: OpenJPA
>>         Issue Type: Improvement
>>           Reporter: Michael Dick
>>           Assignee: Michael Dick
>>           Priority: Minor
>>            Fix For: 1.3.0
>>
>>  Original Estimate: 0.5h
>> Remaining Estimate: 0.5h
>>
>> Per conversation on the users mailing list [1] it would be nice to  
>> make the connection pool used for unit tests configurable. Some  
>> environments are not well suited to handle the current list of  
>> defaults.
>> [1] http://openjpa.markmail.org/message/uctj54wt733wxtp4?q=milosz
>> or
>> http://n2.nabble.com/Test-suite-slow-on-DB2-td1115993.html
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


[jira] Commented: (OPENJPA-734) Commons DBCP parameters should be configurable.

Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636138#action_12636138 ] 

Michael Dick commented on OPENJPA-734:
--------------------------------------

Good point. Currently most of the permissions on the wiki are restricted to OpenJPA developers and admins. If I'm reading the permissions correctly members of the asf-cla group in confluence can also add pages. 

I think we'd be better served to go with something similar to Geronimo's approach (seen here : http://cwiki.apache.org/confluence/display/geronimo/Geronimo+cwiki+documentation+architecture ) with a separate group of contributors who can add to the wiki. 

I'll propose this on the developer mailing list, but I suspect it's policy to require a CLA before anyone can add to an Apache website (since the wiki is our website it may require a CLA as well). 

> Commons DBCP parameters should be configurable. 
> ------------------------------------------------
>
>                 Key: OPENJPA-734
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-734
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>            Priority: Minor
>             Fix For: 1.3.0
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Per conversation on the users mailing list [1] it would be nice to make the connection pool used for unit tests configurable. Some environments are not well suited to handle the current list of defaults. 
> [1] http://openjpa.markmail.org/message/uctj54wt733wxtp4?q=milosz 
> or 
> http://n2.nabble.com/Test-suite-slow-on-DB2-td1115993.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-734) Commons DBCP parameters should be configurable.

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636087#action_12636087 ] 

Milosz Tylenda commented on OPENJPA-734:
----------------------------------------

Thanks for addressing this. I have tested this in my environment and works fine.

I was thinking of updating the Unit Tests page on wiki but it seems this requires some privileges.


> Commons DBCP parameters should be configurable. 
> ------------------------------------------------
>
>                 Key: OPENJPA-734
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-734
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>            Priority: Minor
>             Fix For: 1.3.0
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Per conversation on the users mailing list [1] it would be nice to make the connection pool used for unit tests configurable. Some environments are not well suited to handle the current list of defaults. 
> [1] http://openjpa.markmail.org/message/uctj54wt733wxtp4?q=milosz 
> or 
> http://n2.nabble.com/Test-suite-slow-on-DB2-td1115993.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.